Skip to content

latencystats: cleanup and floating point fixes

Stephen Hemminger dpdk-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest7 patches 4 repliesIn review
  2. v77 patches 3 repliesSuperseded
  3. v68 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v59 patches0 repliesSuperseded
v46 patches3 repliesSuperseded
v35 patches8 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7latencystats: handle fractional cycles per nslib/latencystats/rte_latencystats.c+6 -110 replies
2/7latencystats: do not use floating pointlib/latencystats/rte_latencystats.c+72 -551 reply
3/7latencystats: fix log messageslib/latencystats/rte_latencystats.c+17 -180 replies
4/7latencystats: update include fileslib/latencystats/rte_latencystats.c+14 -50 replies
5/7latencystats: enforce that unused callback function is NULLlib/latencystats/rte_latencystats.c+7 -30 replies
6/7latencystats: add metric for number of sampleslib/latencystats/rte_latencystats.c+12 -80 replies
7/7test: update to latencystats testsapp/test/test_latencystats.c+57 -272 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchTyler RetzlaffMorten BrørupKonstantin Ananyev
1/7
2/7A-b A-b A-b
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/7] latencystats: cleanup and floating point fixes

Latencystats uses unnecessary floating point and is inaccurate if the number of cycles per ns is not an integral value. Cleanup the code and add more tests as well.

v8 - rebase to 25.07-rc1

Stephen Hemminger (7):
latencystats: handle fractional cycles per ns
latencystats: do not use floating point
latencystats: fix log messages
latencystats: update include files
latencystats: enforce that unused callback function is NULL
latencystats: add metric for number of samples
test: update to latencystats tests

 app/test/test_latencystats.c        |  84 +++++++----
 lib/latencystats/rte_latencystats.c | 212 ++++++++++++++++------------
 2 files changed, 177 insertions(+), 119 deletions(-)
Signature · 1 line
2.47.2