hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | hw/cxl/cxl-cdat: Make ct3_load_cdat() return booleanhw/ | +7 | 0 replies | |
| 2/3 | hw/cxl/cxl-cdat: Make ct3_build_cdat() return booleanhw/ | +5 | 0 replies | |
| 3/3 | hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return booleanhw/ hw/ hw/ +1 more | +6 | 2 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Philippe Mathieu-Daudé | Jonathan Cameron |
|---|---|---|
| Series | R-b | A-b |
| 1/3 | ||
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
From: Zhao Liu <[email protected]>
Hi list,
This series is the followup of the previous fix [1] to improve the error handling.
As error.h suggested, the best practice for callee is to return something to indicate success / failure instead of dereferencing @errp.
Thus make cxl_doe_cdat_init() as well as ct3_load_cdat() and ct3_build_cdat() return boolean.
[1]: https://lore.kernel.org/qemu-devel/[email protected]/
Thanks,
Zhao
---
Zhao Liu (3):
hw/cxl/cxl-cdat: Make ct3_load_cdat() return boolean hw/cxl/cxl-cdat: Make ct3_build_cdat() return boolean hw/cxl/cxl-cdat: Make cxl_doe_cdat_init() return boolean
hw/cxl/cxl-cdat.c | 28 +++++++++++++++------------- hw/mem/cxl_type3.c | 3 +-- hw/pci-bridge/cxl_upstream.c | 3 +-- include/hw/cxl/cxl_component.h | 2 +- 4 files changed, 18 insertions(+), 18 deletions(-)
Signature · 1 line
2.34.1