Skip to content

usb: typec: qcom-pmic: fix use-after-free on late probe errors

Johan Hovold linux-arm-msm linux-usb lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: typec: qcom-pmic: fix use-after-free on late probe errorsdrivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c+6 -23 replies
2/2usb: typec: qcom-pmic: fix pdphy start() error handlingdrivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c+7 -43 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDmitry BaryshkovBryan O'DonoghueHeikki Krogerus
1/2R-b R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] usb: typec: qcom-pmic: fix use-after-free on late probe errors

When reviewing a patch updating the qcom-pmic typec driver, I noticed that the error handling is broken and can lead to use-after-free.

This series addresses the use-after-free and also fixes the error handling in the pdphy_start() callback which failed to disable its supply in all error paths.

The latter fix is not marked for stable on purpose as its not a critical fix (I'm sure autosel will disagree).

Johan

Johan Hovold (2):
usb: typec: qcom-pmic: fix use-after-free on late probe errors
usb: typec: qcom-pmic: fix pdphy start() error handling

 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c       |  8 ++++++--
 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 11 +++++++----
 2 files changed, 13 insertions(+), 6 deletions(-)
Signature · 1 line
2.43.2