Skip to content

RFC gve: Implement netdev queue api

Shailend Chand netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9queue_api: define queue apiinclude/linux/netdevice.h include/net/netdev_queues.h+30 -00 replies
2/9gve: Make the RX free queue funcs idempotentdrivers/net/ethernet/google/gve/gve_rx.c+19 -100 replies
3/9gve: Add adminq funcs to add/remove a single Rx queuedrivers/net/ethernet/google/gve/gve_adminq.c drivers/net/ethernet/google/gve/gve_adminq.h+58 -230 replies
4/9gve: Make gve_turn(up|down) ignore stopped queuesdrivers/net/ethernet/google/gve/gve_main.c+10 -00 replies
5/9gve: Make gve_turnup work for nonempty queuesdrivers/net/ethernet/google/gve/gve_main.c+14 -00 replies
6/9gve: Avoid rescheduling napi if on wrong cpudrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_main.c+32 -20 replies
7/9gve: Reset Rx ring state in the ring-stop funcsdrivers/net/ethernet/google/gve/gve_rx.c drivers/net/ethernet/google/gve/gve_rx_dqo.c+120 -300 replies
8/9gve: Account for stopped queues when reading NIC statsdrivers/net/ethernet/google/gve/gve_ethtool.c+9 -40 replies
9/9gve: Implement queue apidrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_dqo.h drivers/net/ethernet/google/gve/gve_main.c +2 more+167 -128 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchMina Almasry
SeriesT-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/9] gve: Implement netdev queue api

Following the discussion on
https://patchwork.kernel.org/project/linux-media/patch/[email protected]/,
the queue api defined by Mina is implemented for gve.

The first patch is just Mina's introduction of the api. The rest of the patches make surgical changes in gve to enable it to work correctly with only a subset of queues present (thus far it had assumed that either all queues are up or all are down). The final patch has the api implementation.

Mina Almasry (1):
queue_api: define queue api

Shailend Chand (8):
gve: Make the RX free queue funcs idempotent
gve: Add adminq funcs to add/remove a single Rx queue
gve: Make gve_turn(up|down) ignore stopped queues
gve: Make gve_turnup work for nonempty queues
gve: Avoid rescheduling napi if on wrong cpu
gve: Reset Rx ring state in the ring-stop funcs
gve: Account for stopped queues when reading NIC stats
gve: Implement queue api

 drivers/net/ethernet/google/gve/gve.h         |   7 +
 drivers/net/ethernet/google/gve/gve_adminq.c  |  79 +++++--
 drivers/net/ethernet/google/gve/gve_adminq.h  |   2 +
 drivers/net/ethernet/google/gve/gve_dqo.h     |   6 +
 drivers/net/ethernet/google/gve/gve_ethtool.c |  13 +-
 drivers/net/ethernet/google/gve/gve_main.c    | 200 +++++++++++++++++-
 drivers/net/ethernet/google/gve/gve_rx.c      |  89 +++++---
 drivers/net/ethernet/google/gve/gve_rx_dqo.c  | 114 +++++++---
 include/linux/netdevice.h                     |   3 +
 include/net/netdev_queues.h                   |  27 +++
 10 files changed, 459 insertions(+), 81 deletions(-)
Signature · 1 line
2.44.0.769.g3c40516874-goog