Skip to content

tcp: avoid sending too small packets

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3tcp: remove dubious FIN exception from tcp_cwnd_test()net/ipv4/tcp_output.c+5 -130 repliesApplied
2/3tcp: call tcp_set_skb_tso_segs() from tcp_write_xmit()net/ipv4/tcp_output.c+14 -120 repliesApplied
3/3tcp: try to send bigger TSO packetsnet/ipv4/tcp_output.c+36 -22 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] tcp: avoid sending too small packets

tcp_sendmsg() cooks 'large' skbs, that are later split if needed from tcp_write_xmit().

After a split, the leftover skb size is smaller than the optimal size, and this causes a performance drop.

In this series, tcp_grow_skb() helper is added to shift payload from the second skb in the write queue to the first skb to always send optimal sized skbs.

This increases TSO efficiency, and decreases number of ACK packets.

Eric Dumazet (3):
tcp: remove dubious FIN exception from tcp_cwnd_test()
tcp: call tcp_set_skb_tso_segs() from tcp_write_xmit()
tcp: try to send bigger TSO packets

 net/ipv4/tcp_output.c | 78 +++++++++++++++++++++++++++++--------------
 1 file changed, 53 insertions(+), 25 deletions(-)
Signature · 1 line
2.44.0.769.g3c40516874-goog