Skip to content

ASoC: Intel: avs: Refactor IRQ handling

Cezary Rojewski alsa-devel linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: Intel: avs: New IRQ handling implementationsound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/cldma.c +6 more+240 -00 replies
2/2ASoC: Intel: avs: Remove unused IRQ-related codesound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/cldma.c +6 more+7 -2490 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: Intel: avs: Refactor IRQ handling

The existing code can be both improved and simplified. To make this change easier to manage, first add new implementation and then remove deadcode in a separate patch.

Simplification achieved with:

- reduce the amount of resources requested by the driver i.e.: IPC and CLDMA request_irq() merged into one
- reduce the number of DSP ops from 2 to 1:
irq_handler/thread() vs dsp_interrupt()
- drop ambiguity around CLDMA interrupt, let skl.c handle that explicitly as it is the only user

With that done, switch to the new implementation and remove unused members. While the change is non-trivial, from functional perspective status quo is achieved.

Cezary Rojewski (2):
ASoC: Intel: avs: New IRQ handling implementation
ASoC: Intel: avs: Remove unused IRQ-related code

 sound/soc/intel/avs/apl.c   | 20 +++++++-
 sound/soc/intel/avs/avs.h   |  8 ++--
 sound/soc/intel/avs/cldma.c | 42 ++++-------------
 sound/soc/intel/avs/cldma.h |  1 +
 sound/soc/intel/avs/cnl.c   | 91 ++++++++++++++++++++++++-------------
 sound/soc/intel/avs/core.c  | 85 ++++++++++++++++------------------
 sound/soc/intel/avs/icl.c   |  3 +-
 sound/soc/intel/avs/ipc.c   | 48 -------------------
 sound/soc/intel/avs/skl.c   | 73 +++++++++++++++++++++--------
 sound/soc/intel/avs/tgl.c   |  3 +-
 10 files changed, 186 insertions(+), 188 deletions(-)
Signature · 1 line
2.25.1