Skip to content

KVM/x86: Enhancements to static calls

Wei Wang kvm lkml 3 versions – Applied

Status from this message: Applied to kvm-x86 static_calls. I may or may not rebase these commits

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 4 repliesApplied
  2. v33 patches 3 repliesSuperseded
  3. v25 patches 6 repliesSuperseded

Changes in v4 from the cover letter

- Rename KVM_X86_CALL() to kvm_x86_call() and KVM_PMU_CALL() to kvm_pmu_call() as they resemble functions, so the lower-case style looks more readable.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3KVM: x86: Replace static_call_cond() with static_call()arch/x86/include/asm/kvm_host.h arch/x86/kvm/irq.c arch/x86/kvm/lapic.c +2 more+30 -300 replies
2/3KVM: x86: Introduce kvm_x86_call() to simplify static calls of kvm_x86_opsarch/x86/include/asm/kvm_host.h arch/x86/kvm/cpuid.c arch/x86/kvm/hyperv.c +13 more+246 -2340 replies
3/3KVM: x86/pmu: Add kvm_pmu_call() to simplify static calls of kvm_pmu_opsarch/x86/include/asm/kvm_host.h arch/x86/kvm/pmu.c+13 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] KVM/x86: Enhancements to static calls

This patchset introduces the kvm_x86_call() and kvm_pmu_call() macros to streamline the usage of static calls of kvm_x86_ops and kvm_pmu_ops. The current static_call() usage is a bit verbose and can lead to code alignment challenges, and the addition of kvm_x86_ prefix to hooks at the static_call() sites hinders code readability and navigation. The use of static_call_cond() is essentially the same as static_call() on x86, so it is replaced by static_call() to simplify the code. The changes have gone through my tests (guest launch, a few vPMU tests, live migration tests) without an issue.

v3->v4 change:
- Rename KVM_X86_CALL() to kvm_x86_call() and KVM_PMU_CALL() to kvm_pmu_call() as they resemble functions, so the lower-case style looks more readable.

v2->v3 changes:
- Change the KVM_X86_CALL() definition to have the parameters in their owen paratheses.
- Update the .get_cpl() hook in pmu.c to use KVM_X86_CALL(). (it was omitted in v2)

v1->v2 changes:
- Replace static_call_cond() with static_call()
- Rename KVM_X86_SC to KVM_X86_CALL, and updated all the call sites
- Add KVM_PMU_CALL()
- Add patch 4 and 5 to review the idea of removing KVM_X86_OP_OPTIONAL

Wei Wang (3):
KVM: x86: Replace static_call_cond() with static_call()
KVM: x86: Introduce kvm_x86_call() to simplify static calls of

    kvm_x86_ops

KVM: x86/pmu: Add kvm_pmu_call() to simplify static calls of
kvm_pmu_ops

 arch/x86/include/asm/kvm_host.h |  11 +-
 arch/x86/kvm/cpuid.c            |   2 +-
 arch/x86/kvm/hyperv.c           |   6 +-
 arch/x86/kvm/irq.c              |   2 +-
 arch/x86/kvm/kvm_cache_regs.h   |  10 +-
 arch/x86/kvm/lapic.c            |  42 +++--
 arch/x86/kvm/lapic.h            |   2 +-
 arch/x86/kvm/mmu.h              |   6 +-
 arch/x86/kvm/mmu/mmu.c          |   4 +-
 arch/x86/kvm/mmu/spte.c         |   4 +-
 arch/x86/kvm/pmu.c              |  29 +--
 arch/x86/kvm/smm.c              |  44 ++---
 arch/x86/kvm/trace.h            |  15 +-
 arch/x86/kvm/x86.c              | 322 ++++++++++++++++----------------
 arch/x86/kvm/x86.h              |   2 +-
 arch/x86/kvm/xen.c              |   4 +-
 16 files changed, 259 insertions(+), 246 deletions(-)

base-commit: aec147c18856fa7115e14b9ad6a91c3ed2cf2e19

Signature · 1 line
2.27.0