Skip to content

Introduce --btf_features=+extra_features syntax

Arnaldo Carvalho de Melo bpf dwarves 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pahole: Factor out routine to process "--btf_features=all"pahole.c+10 -70 replies
2/2pahole: Allow asking for extra features using the '+' prefix in --btf_featuresman-pages/pahole.1 pahole.c tests/reproducible_build.sh+13 -15 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHES 0/2] Introduce --btf_features=+extra_features syntax

Hi,

Please take a look if you agree this is a more compact, less
confusing way of asking for the set of standard BTF features + some extra features such as 'reproducible_build'.

We have this in perf, for things like:

⬢[acme@toolbox pahole]$ perf report -h -F

Usage: perf report [<options>]

-F, --fields <key[,keys...]>
output field(s): overhead period sample overhead overhead_sys overhead_us overhead_guest_sys overhead_guest_us overhead_children sample period weight1 weight2 weight3 ins_lat retire_lat p_stage_cyc pid comm dso symbol parent cpu socket srcline srcfile local_weight weight transaction trace symbol_size dso_size cgroup cgroup_id ipc_null time code_page_size local_ins_lat ins_lat local_p_stage_cyc p_stage_cyc addr local_retire_lat retire_lat simd type typeoff symoff dso_from dso_to symbol_from symbol_to mispredict abort in_tx cycles srcline_from srcline_to ipc_lbr addr_from addr_to symbol_daddr dso_daddr locked tlb mem snoop dcacheline symbol_iaddr phys_daddr data_page_size blocked

⬢[acme@toolbox pahole]$

From the 'perf report' man page for '-F':

If the keys starts with a prefix '+', then it will append the specified field(s) to the default field order. For example: perf report -F +period,sample.

- Arnaldo

Arnaldo Carvalho de Melo (2):
pahole: Factor out routine to process "--btf_features=all"
pahole: Allow asking for extra features using the '+' prefix in
--btf_features

 man-pages/pahole.1          |  6 ++++++
 pahole.c                    | 23 ++++++++++++++++-------
 tests/reproducible_build.sh |  2 +-
 3 files changed, 23 insertions(+), 8 deletions(-)
Signature · 1 line
2.44.0