Skip to content

add support for EXAR XR20M1172 UART

Konstantin Pugin linux-devicetree linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v7 Latest3 patches 12 repliesIn review

Changes in v7 from the cover letter

- Added missed tag
- Added missed v5 fixes

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SENDdrivers/tty/serial/sc16is7xx.c+1 -11 reply
2/3dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UARTDocumentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml+1 -02 replies
3/3serial: sc16is7xx: add support for EXAR XR20M1172 UARTdrivers/tty/serial/Kconfig drivers/tty/serial/sc16is7xx.c drivers/tty/serial/sc16is7xx.h +2 more+62 -52 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiVladimir ZapolskiyHugo Villeneuve
1/3T-b
2/3A-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/3] add support for EXAR XR20M1172 UART

EXAR XR20M1172 UART is mostly SC16IS762-compatible, but it has additional register which can change UART multiplier to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this flag to guard access to its specific DLD register. It seems than other EXAR SPI UART modules also have this register, but I tested only XR20M1172.
Yes, in datasheet this register is called "DLD - Divisor Fractional" or "DLD - Divisor Fractional Register", calling depends on datasheet version.

I am sorry about too many submissions and top post reply. About second -
I do not know how to reply properly to this ML from GMail phone app. About first - I just get very good feedback from Andy Shevchenko, and want to fix his review picks ASAP.

Changes in v2:
- use full name in git authorship

Changes in v3:
- change formatting of commit messages to unify width
- rework commit messages according to code review
- add XR20M117X namespace for EXAR-specific register
- do not use UPF_MAGIC_MULTIPLIER for checking EXAR chip,

    use s->devtype directly

- replace while loop to fls function and expanded check
- sort compatibles
- reformat multiline comment.

Changes in v4:
- rebase onto tty-next branch
- added Kconfig mention of the chip
- used rounddown_power_of_two instead of fls and manual shift
- used FIELD_PREP instead of custom macro
- removed has_dld bit from common struct, replaced by check function,

    which checks directly by s->devtype

- fixed tab count
- properly apply Vladimir Zapolskiy's tag to patch 2 only

Changes in v5:
- fixes for tty-next branch
- address a new code review picks
- send properly to all participants
- added Ack tag

Changes in v6:
- KConfig fixes
- New code review fixes

Changes in v7:
- Added missed tag
- Added missed v5 fixes

Konstantin Pugin (3):
serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART
serial: sc16is7xx: add support for EXAR XR20M1172 UART

 .../bindings/serial/nxp,sc16is7xx.yaml        |  1 +
 drivers/tty/serial/Kconfig                    |  3 +-
 drivers/tty/serial/sc16is7xx.c                | 63 +++++++++++++++++--
 drivers/tty/serial/sc16is7xx.h                |  1 +
 drivers/tty/serial/sc16is7xx_i2c.c            |  1 +
 drivers/tty/serial/sc16is7xx_spi.c            |  1 +
 6 files changed, 64 insertions(+), 6 deletions(-)

base-commit: f70f95b485d78838ad28dbec804b986d11ad7bb0

Signature · 1 line
2.34.1