Skip to content

drm: zynqmp_dp: IRQ cleanups and debugfs support

Sean Anderson dri-devel linux-arm-kernel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 7 repliesIn review
  2. v510 patches 5 repliesSuperseded
  3. v413 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v313 patches8 repliesSuperseded

Changes in v6 from the cover letter

- Unplug DRM device before removal
- Fix hang upon driver removal
- Rebase onto drm-misc/drm-misc-next

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm: zynqmp_kms: Unplug DRM device before removaldrivers/gpu/drm/xlnx/zynqmp_kms.c+1 -10 replies
2/8drm: zynqmp_dp: Add lockingdrivers/gpu/drm/xlnx/zynqmp_dp.c+18 -00 replies
3/8drm: zynqmp_dp: Don't retrain the link in our IRQdrivers/gpu/drm/xlnx/zynqmp_dp.c+29 -160 replies
4/8drm: zynqmp_dp: Convert to a hard IRQdrivers/gpu/drm/xlnx/zynqmp_dp.c+3 -41 reply
5/8drm: zynqmp_dp: Use AUX IRQs instead of pollingdrivers/gpu/drm/xlnx/zynqmp_dp.c+25 -100 replies
6/8drm: zynqmp_dp: Split off several helper functionsdrivers/gpu/drm/xlnx/zynqmp_dp.c+34 -150 replies
7/8drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_funcdrivers/gpu/drm/xlnx/zynqmp_dp.c+18 -60 replies
8/8drm: zynqmp_dp: Add debugfs interface for compliance testingDocumentation/gpu/drivers.rst Documentation/gpu/zynqmp.rst MAINTAINERS +1 more+830 -30 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartTomi Valkeinen
1/8
2/8
3/8
4/8R-b
5/8
6/8R-b R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/8] drm: zynqmp_dp: IRQ cleanups and debugfs support

This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it adds debugfs support. The intent is to enable compliance testing or to help debug signal-integrity issues.

Previously, I discussed converting the HPD work(s) to a threaded IRQ. I did not end up doing that for this series since the steps would be

- Add locking
- Move link retraining to a work function
- Harden the IRQ
- Merge the works into a threaded IRQ (omitted)

Which with the exception of the final step is the same as leaving those works as-is. Conversion to a threaded IRQ can be done as a follow-up.

Changes in v6:
- Unplug DRM device before removal
- Fix hang upon driver removal
- Rebase onto drm-misc/drm-misc-next

Changes in v5:
- Rebase onto drm-misc/drm-misc-next

Changes in v4:
- Rebase onto drm/drm-next

Changes in v3:
- Convert to a hard IRQ
- Use AUX IRQs instead of polling
- Take dp->lock in zynqmp_dp_hpd_work_func

Changes in v2:
- Split off the HPD IRQ work into another commit
- Expand the commit message
- Document hpd_irq_work
- Document debugfs files
- Add ignore_aux_errors and ignore_hpd debugfs files to replace earlier implicit functionality
- Attempt to fix unreproducable, spurious build warning
- Drop "Optionally ignore DPCD errors" in favor of a debugfs file directly affecting zynqmp_dp_aux_transfer.

Sean Anderson (8):
drm: zynqmp_kms: Unplug DRM device before removal
drm: zynqmp_dp: Add locking
drm: zynqmp_dp: Don't retrain the link in our IRQ
drm: zynqmp_dp: Convert to a hard IRQ
drm: zynqmp_dp: Use AUX IRQs instead of polling
drm: zynqmp_dp: Split off several helper functions
drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func
drm: zynqmp_dp: Add debugfs interface for compliance testing

 Documentation/gpu/drivers.rst     |   1 +
 Documentation/gpu/zynqmp.rst      | 149 ++++++
 MAINTAINERS                       |   1 +
 drivers/gpu/drm/xlnx/zynqmp_dp.c  | 846 ++++++++++++++++++++++++++++--
 drivers/gpu/drm/xlnx/zynqmp_kms.c |   2 +-
 5 files changed, 951 insertions(+), 48 deletions(-)
 create mode 100644 Documentation/gpu/zynqmp.rst
Signature · 1 line
2.35.1.1320.gc452695387.dirty