Skip to content

X86: Alias isa-bios area and clean up

Bernhard Beschow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4hw/i386/pc_sysfw: Remove unused parameter from pc_isa_bios_init()hw/i386/pc_sysfw.c+2 -31 reply
2/4hw/i386/pc_sysfw: Alias rather than copy isa-bios regionhw/i386/pc_sysfw.c+2 -110 replies
3/4hw/i386/x86: Eliminate two if statements in x86_bios_rom_init()hw/i386/x86.c+2 -61 reply
4/4hw/i386: Consolidate isa-bios creationhw/i386/pc_sysfw.c hw/i386/x86.c include/hw/i386/x86.h+24 -352 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/4R-b
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] X86: Alias isa-bios area and clean up

This series changes the "isa-bios" MemoryRegion to be an alias rather than a copy in the pflash case. This fixes issuing pflash commands in the isa-bios region which matches real hardware and which some real-world legacy bioses I'm running rely on. Furthermore, aliasing in the isa-bios area is already the current behavior in the bios (a.k.a. ROM) case, so this series consolidates behavior.

The consolidateion results in duplicate code which is resolved in the second half (patches 3 and 4) in this series.

Question: AFAIU, patch 2 changes the behavior for SEV-enabled guests since the isa-bios area is now encrypted. Does this need compat machinery or is it a bugfix?

Testing done:
* make check with qemu-system-x86_64 (QEMU 8.2.2) installed. All tests including migration tests pass.
* make check-avocado

Best regards,
Bernhard

Bernhard Beschow (4):
hw/i386/pc_sysfw: Remove unused parameter from pc_isa_bios_init() hw/i386/pc_sysfw: Alias rather than copy isa-bios region hw/i386/x86: Eliminate two if statements in x86_bios_rom_init() hw/i386: Consolidate isa-bios creation

 include/hw/i386/x86.h |  2 ++
 hw/i386/pc_sysfw.c    | 38 ++++----------------------------------
 hw/i386/x86.c         | 35 +++++++++++++++++++----------------
 3 files changed, 25 insertions(+), 50 deletions(-)
Signature · 1 line
2.44.0