Skip to content

clk: Add kunit tests for fixed rate and parent data

Stephen Boyd linux-clk linux-devicetree linux-kselftest linux-patches lkml 5 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest8 patches 25 repliesApplied
  2. v78 patches 10 repliesApplied
  3. v68 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v511 patches18 repliesSuperseded
v410 patches23 repliesSuperseded

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/8of/platform: Allow overlays to create platform devices from the root nodedrivers/of/platform.c+6 -31 reply
2/8of: Add test managed wrappers for of_overlay_apply()/of_node_put()Documentation/dev-tools/kunit/api/index.rst Documentation/dev-tools/kunit/api/of.rst drivers/of/Makefile +2 more+217 -01 reply
3/8dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friendsDocumentation/devicetree/bindings/vendor-prefixes.yaml+2 -01 reply
4/8of: Add a KUnit test for overlays and test managed APIsdrivers/of/.kunitconfig drivers/of/Kconfig drivers/of/Makefile +2 more+137 -01 reply
5/8platform: Add test managed platform_device/driver APIsDocumentation/dev-tools/kunit/api/index.rst Documentation/dev-tools/kunit/api/platformdevice.rst drivers/base/dd.c +4 more+565 -12 replies
6/8clk: Add test managed clk provider/consumer APIsDocumentation/dev-tools/kunit/api/clk.rst Documentation/dev-tools/kunit/api/index.rst drivers/clk/Makefile +2 more+255 -01 reply
7/8clk: Add KUnit tests for clk fixed rate basic typedrivers/clk/.kunitconfig drivers/clk/Kconfig drivers/clk/Makefile +3 more+420 -01 reply
8/8clk: Add KUnit tests for clks registered with struct clk_parent_datadrivers/clk/Kconfig drivers/clk/Makefile drivers/clk/clk_parent_data_test.h +2 more+495 -217 replies

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchRob Herring (Arm)David GowGreg Kroah-Hartman
1/8R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8
7/8
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/8] clk: Add kunit tests for fixed rate and parent data

This patch series adds unit tests for the clk fixed rate basic type and the clk registration functions that use struct clk_parent_data. To get there, we add support for loading device tree overlays onto the live DTB along with probing platform drivers to bind to device nodes in the overlays. With this series, we're able to exercise some of the code in the common clk framework that uses devicetree lookups to find parents and the fixed rate clk code that scans device tree directly and creates clks. Please review.

I Cced everyone to all the patches so they get the full context. I'm hoping I can take the whole pile through the clk tree as they all build upon each other. Or the DT part can be merged through the DT tree to reduce the dependencies.

Changes from v7: https://lore.kernel.org/r/[email protected]
* Support modular builds properly by compiling overlay with tests into one .ko
* Fold in thinko fix from Geert to DT overlay application patch
* Export device_is_bound() to fix module build
* Add more module license and description

Changes from v6: https://lore.kernel.org/r/[email protected]
* Fix kasan error in platform test by fixing the condition to check for correct free callback
* Add module descriptions to new modules

Changes from v5: https://lore.kernel.org/r/[email protected]
* Pick up reviewed-by tags
* Drop test vendor prefix bindings as dtschema allows anything now
* Use of_node_put_kunit() more to plug some reference leaks
* Select DTC config to avoid compile fails because of missing dtc
* Don't skip for OF_OVERLAY in overlay tests because they depend on it

Changes from v4: https://lore.kernel.org/r/[email protected]
* Picked up reviewed-by tags
* Check for non-NULL device pointers before calling put_device()
* Fix CFI issues with kunit actions
* Introduce platform_device_prepare_wait_for_probe() helper to wait for a platform device to probe
* Move platform code to lib/kunit and rename functions to have kunit prefix
* Fix issue with platform wrappers messing up reference counting because they used kunit actions
* New patch to populate overlay devices on root node for powerpc
* Make fixed-rate binding generic single clk consumer binding

Changes from v3: https://lore.kernel.org/r/[email protected]
* No longer depend on Frank's series[1] because it was merged upstream[2]
* Use kunit_add_action_or_reset() to shorten code
* Skip tests properly when CONFIG_OF_OVERLAY isn't set

Changes from v2: https://lore.kernel.org/r/[email protected]
* Overlays don't depend on __symbols__ node
* Depend on Frank's always create root node if CONFIG_OF series[1]
* Added kernel-doc to KUnit API doc
* Fixed some kernel-doc on functions
* More test cases for fixed rate clk

Changes from v1: https://lore.kernel.org/r/[email protected]
* Don't depend on UML, use unittest data approach to attach nodes
* Introduce overlay loading API for KUnit
* Move platform_device KUnit code to drivers/base/test
* Use #define macros for constants shared between unit tests and overlays
* Settle on "test" as a vendor prefix
* Make KUnit wrappers have "_kunit" postfix

[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]

Stephen Boyd (8):
of/platform: Allow overlays to create platform devices from the root
node
of: Add test managed wrappers for of_overlay_apply()/of_node_put()
dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends
of: Add a KUnit test for overlays and test managed APIs
platform: Add test managed platform_device/driver APIs
clk: Add test managed clk provider/consumer APIs
clk: Add KUnit tests for clk fixed rate basic type
clk: Add KUnit tests for clks registered with struct clk_parent_data

 Documentation/dev-tools/kunit/api/clk.rst     |  10 +
 Documentation/dev-tools/kunit/api/index.rst   |  21 +
 Documentation/dev-tools/kunit/api/of.rst      |  13 +
 .../dev-tools/kunit/api/platformdevice.rst    |  10 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 drivers/base/dd.c                             |   1 +
 drivers/clk/.kunitconfig                      |   2 +
 drivers/clk/Kconfig                           |  11 +
 drivers/clk/Makefile                          |  11 +-
 drivers/clk/clk-fixed-rate_test.c             | 380 +++++++++++++++
 drivers/clk/clk-fixed-rate_test.h             |   8 +
 drivers/clk/clk_kunit_helpers.c               | 207 ++++++++
 drivers/clk/clk_parent_data_test.h            |  10 +
 drivers/clk/clk_test.c                        | 453 +++++++++++++++++-
 drivers/clk/kunit_clk_fixed_rate_test.dtso    |  19 +
 drivers/clk/kunit_clk_parent_data_test.dtso   |  28 ++
 drivers/of/.kunitconfig                       |   1 +
 drivers/of/Kconfig                            |  10 +
 drivers/of/Makefile                           |   3 +
 drivers/of/kunit_overlay_test.dtso            |   9 +
 drivers/of/of_kunit_helpers.c                 |  77 +++
 drivers/of/overlay_test.c                     | 115 +++++
 drivers/of/platform.c                         |   9 +-
 include/kunit/clk.h                           |  28 ++
 include/kunit/of.h                            | 115 +++++
 include/kunit/platform_device.h               |  20 +
 lib/kunit/Makefile                            |   4 +-
 lib/kunit/platform-test.c                     | 224 +++++++++
 lib/kunit/platform.c                          | 302 ++++++++++++
 29 files changed, 2097 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/dev-tools/kunit/api/clk.rst
 create mode 100644 Documentation/dev-tools/kunit/api/of.rst
 create mode 100644 Documentation/dev-tools/kunit/api/platformdevice.rst
 create mode 100644 drivers/clk/clk-fixed-rate_test.c
 create mode 100644 drivers/clk/clk-fixed-rate_test.h
 create mode 100644 drivers/clk/clk_kunit_helpers.c
 create mode 100644 drivers/clk/clk_parent_data_test.h
 create mode 100644 drivers/clk/kunit_clk_fixed_rate_test.dtso
 create mode 100644 drivers/clk/kunit_clk_parent_data_test.dtso
 create mode 100644 drivers/of/kunit_overlay_test.dtso
 create mode 100644 drivers/of/of_kunit_helpers.c
 create mode 100644 drivers/of/overlay_test.c
 create mode 100644 include/kunit/clk.h
 create mode 100644 include/kunit/of.h
 create mode 100644 include/kunit/platform_device.h
 create mode 100644 lib/kunit/platform-test.c
 create mode 100644 lib/kunit/platform.c

base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git