Skip to content

Generic line based metadata, without sensor API changes

Sakari Ailus linux-media 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 0 repliesNew
  2. v214 patches 0 repliesSuperseded
  3. v114 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Fix glossary term referencing (thanks to Hans!).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14media: v4l2-subdev: Clearly document that the crop API won't be extendedDocumentation/userspace-api/media/v4l/vidioc-subdev-g-crop.rst include/uapi/linux/v4l2-subdev.h+7 -30 replies
2/14media: Documentation: Add "stream" into glossaryDocumentation/userspace-api/media/glossary.rst+5 -00 replies
3/14media: uapi: Add generic serial metadata mbus formatsDocumentation/userspace-api/media/glossary.rst Documentation/userspace-api/media/v4l/subdev-formats.rst include/uapi/linux/media-bus-format.h+270 -00 replies
4/14media: uapi: Document which mbus format fields are valid for metadataDocumentation/userspace-api/media/v4l/subdev-formats.rst include/uapi/linux/v4l2-mediabus.h+20 -130 replies
5/14media: uapi: v4l: Add generic 8-bit metadata format definitionsDocumentation/userspace-api/media/v4l/dev-subdev.rst Documentation/userspace-api/media/v4l/meta-formats.rst Documentation/userspace-api/media/v4l/metafmt-generic.rst +2 more+359 -10 replies
6/14media: v4l: Support line-based metadata captureDocumentation/userspace-api/media/v4l/dev-meta.rst Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst Documentation/userspace-api/media/videodev2.h.rst.exceptions +2 more+42 -20 replies
7/14media: v4l: Set line based metadata flag in V4L2 coredrivers/media/v4l2-core/v4l2-ioctl.c include/uapi/linux/videodev2.h+20 -00 replies
8/14media: Documentation: Additional streams generally don't harm captureDocumentation/userspace-api/media/v4l/dev-subdev.rst+3 -30 replies
9/14media: Documentation: Document S_ROUTING behaviourDocumentation/userspace-api/media/v4l/dev-subdev.rst+23 -00 replies
10/14media: v4l: subdev: Add a function to lock two sub-device states, use itdrivers/media/v4l2-core/v4l2-subdev.c include/media/v4l2-subdev.h+44 -80 replies
11/14media: v4l: subdev: Copy argument back to user also for S_ROUTINGdrivers/media/v4l2-core/v4l2-ioctl.c+6 -30 replies
12/14media: v4l: subdev: Add len_routes field to struct v4l2_subdev_routingDocumentation/userspace-api/media/v4l/vidioc-subdev-g-routing.rst drivers/media/v4l2-core/v4l2-ioctl.c drivers/media/v4l2-core/v4l2-subdev.c +2 more+49 -250 replies
13/14media: v4l: subdev: Return routes set using S_ROUTINGDocumentation/userspace-api/media/v4l/vidioc-subdev-g-routing.rst drivers/media/v4l2-core/v4l2-subdev.c+13 -60 replies
14/14media: v4l: subdev: Add trivial set_routing supportdrivers/media/v4l2-core/v4l2-subdev.c+14 -00 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchSakari AilusTomi ValkeinenLaurent PinchartJulien Massot
1/14A-b R-b
2/14R-b R-b
3/14R-b
4/14R-b R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b R-b
11/14R-b R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/14] Generic line based metadata, without sensor API changes

Hello everyone,

I've split these patches off the metadata set [1], it'll still take more time to merge the internal pad support as it is evident we need to properly define the recommended sensor APIs to merge the drivers that are using them.

In the meantime, these patches are seen as what can be merged for 6.10.

The patches include changes to the routing API before the internal pads.

[1] <URL:https://lore.kernel.org/linux-media/[email protected]/T/#t>

changes since v2:

- Fix glossary term referencing (thanks to Hans!).

changes since v1:

- Improve len_routes field documentation in struct v4l2_subdev_routing.

changes since v9 metadata set:

- Fix metadata format documentation.

- Improve language of struct v4l2_subdev_format field documentation when it comes to metadata.

- Improved documentation for routing API.

- Set (and unset) the V4L2_FMT_FLAG_META_LINE_BASED flag in the framework based on the format, don't rely on the driver to do it. Added a comment to the format list to remind developers to update v4l_fill_fmtdesc when adding new metadata formats.

- Drop the patch that moved G_ROUTING below S_ROUTING handling in v4l2-subdev.c. It's no longer needed.

Laurent Pinchart (1):
media: v4l2-subdev: Clearly document that the crop API won't be
extended

Sakari Ailus (13):
media: Documentation: Add "stream" into glossary
media: uapi: Add generic serial metadata mbus formats
media: uapi: Document which mbus format fields are valid for metadata
media: uapi: v4l: Add generic 8-bit metadata format definitions
media: v4l: Support line-based metadata capture
media: v4l: Set line based metadata flag in V4L2 core
media: Documentation: Additional streams generally don't harm capture
media: Documentation: Document S_ROUTING behaviour
media: v4l: subdev: Add a function to lock two sub-device states, use
it
media: v4l: subdev: Copy argument back to user also for S_ROUTING
media: v4l: subdev: Add len_routes field to struct v4l2_subdev_routing
media: v4l: subdev: Return routes set using S_ROUTING
media: v4l: subdev: Add trivial set_routing support

 .../userspace-api/media/glossary.rst          |  12 +
 .../userspace-api/media/v4l/dev-meta.rst      |  21 ++
 .../userspace-api/media/v4l/dev-subdev.rst    |  31 +-
 .../userspace-api/media/v4l/meta-formats.rst  |   3 +-
 .../media/v4l/metafmt-generic.rst             | 340 ++++++++++++++++++
 .../media/v4l/subdev-formats.rst              | 269 +++++++++++++-
 .../media/v4l/vidioc-enum-fmt.rst             |   7 +
 .../media/v4l/vidioc-subdev-g-crop.rst        |   6 +-
 .../media/v4l/vidioc-subdev-g-routing.rst     |  51 ++-
 .../media/videodev2.h.rst.exceptions          |   1 +
 drivers/media/v4l2-core/v4l2-ioctl.c          |  41 ++-
 drivers/media/v4l2-core/v4l2-subdev.c         |  50 ++-
 include/media/v4l2-subdev.h                   |  42 +++
 include/uapi/linux/media-bus-format.h         |   9 +
 include/uapi/linux/v4l2-mediabus.h            |  18 +-
 include/uapi/linux/v4l2-subdev.h              |  14 +-
 include/uapi/linux/videodev2.h                |  22 ++
 17 files changed, 874 insertions(+), 63 deletions(-)
 create mode 100644 Documentation/userspace-api/media/v4l/metafmt-generic.rst

base-commit: faa4364bef2ec0060de381ff028d1d836600a381

Signature · 1 line
2.39.2