Skip to content

lib/gpgpu: add shader support

Andrzej Hajda igt-dev 8 versions – In review

Get series with b4
b4 am [email protected] change-id 20240425-iga64_inline_ups-438ddfd6023f

Versions newest first

  1. v8 Latest5 patches 2 repliesIn review
  2. v75 patches 10 repliesSuperseded
  3. v65 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v55 patches7 repliesSuperseded
v45 patches1 replySuperseded
v35 patches0 repliesSuperseded
v25 patches1 replySuperseded
v14 patches10 repliesSuperseded

Changes in v8 from the cover letter

- added sanity check for assemblies,
- added asserts after memory allocations,
- cosmetic changes,
- added r-b/a-b tags, one patch left :)

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5lib/gpu_cmds: add Xe_LP version of emit_vfe_statelib/gpu_cmds.c lib/gpu_cmds.h+52 -60 replies
2/5lib/gpgpu_shader: tooling for preparing and running gpgpu shaderslib/gpgpu_shader.c lib/gpgpu_shader.h lib/meson.build+251 -00 replies
3/5lib/gpgpu_shader: add inline support for iga64 assemblylib/gpgpu_shader.c lib/gpgpu_shader.h lib/iga64_generated_codes.c +5 more+239 -41 reply
4/5lib/igt_sysfs: add helpers to access engine sysfs directorylib/igt_sysfs.c lib/igt_sysfs.h+74 -00 replies
5/5intel/xe_exec_sip: add shader sanity testlib/gpgpu_shader.c lib/iga64_generated_codes.c tests/intel/xe_exec_sip.c +1 more+342 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDominik GrzegorzekZbigniew KempczyńskiKamil Konieczny
1/5R-b
2/5A-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/5] lib/gpgpu: add shader support

This patchset adds shader support to mainline IGT. Together with iga64 inline assembly and demo test using both.

The patches were cherry-picked/trimmed from internal branch, quite painful process. I hope I have not cut off too much :)

v3:
- bumped minimal meson version,
- use old string literals to satisfy clang
v4:
- bump meson to latest version supported by CI builder
v5:
- just small update, to ping potential reviewers :)
- revert back required meson version, instead use old syntax to make CI happy v6:
- addressed most Kamil's comments - added docs for public functions, generator script moved to scripts, added ifdef guards to iga64_macros.h, fixed docs and description in xe_exec_sip test
v7:
- addressed checkpatch issues,
- removed "Driver requirement: xe" tag
v8:
- added sanity check for assemblies,
- added asserts after memory allocations,
- cosmetic changes,
- added r-b/a-b tags, one patch left :)

To: [email protected]
Cc: Kamil Konieczny <[email protected]>
Cc: Dominik Grzegorzek <[email protected]>
Cc: Christoph Manszewski <[email protected]>
Cc: Zbigniew Kempczyński <[email protected]>
Cc: Gwan-gyeong Mun <[email protected]>

---
- Link to v1: https://lore.kernel.org/r/[email protected]
- Link to v2: https://lore.kernel.org/r/[email protected]
- Link to v3: https://lore.kernel.org/r/[email protected]
- Link to v4: https://lore.kernel.org/r/[email protected]
- Link to v5: https://lore.kernel.org/r/[email protected]
- Link to v6: https://lore.kernel.org/r/[email protected]
- Link to v7: https://lore.kernel.org/r/[email protected]

---
Andrzej Hajda (5):
lib/gpu_cmds: add Xe_LP version of emit_vfe_state lib/gpgpu_shader: tooling for preparing and running gpgpu shaders lib/gpgpu_shader: add inline support for iga64 assembly lib/igt_sysfs: add helpers to access engine sysfs directory intel/xe_exec_sip: add shader sanity test

 lib/gpgpu_shader.c           | 315 +++++++++++++++++++++++++++++++++++++++++++
 lib/gpgpu_shader.h           |  63 +++++++++
 lib/gpu_cmds.c               |  52 ++++++-
 lib/gpu_cmds.h               |   6 +
 lib/iga64_generated_codes.c  |  87 ++++++++++++
 lib/iga64_macros.h           |  16 +++
 lib/igt_sysfs.c              |  71 ++++++++++
 lib/igt_sysfs.h              |   3 +
 lib/meson.build              |  18 +++
 meson.build                  |   9 +-
 scripts/generate_iga64_codes | 129 ++++++++++++++++++
 scripts/meson.build          |   1 +
 tests/intel/xe_exec_sip.c    | 196 +++++++++++++++++++++++++++
 tests/meson.build            |   1 +
 14 files changed, 957 insertions(+), 10 deletions(-)

---
base-commit: f13702b8e4e847c56da3ef6f0969065d686049c5
change-id: 20240425-iga64_inline_ups-438ddfd6023f

Best regards,

Signature · 1 line
Andrzej Hajda <[email protected]>