Skip to content

Some refactoring and maybe a memory accounting fixlet

Tvrtko Ursulin amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/amdgpu: Add amdgpu_bo_is_vm_bo helperdrivers/gpu/drm/amd/amdgpu/amdgpu_gem.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.h drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c+28 -193 replies
2/3drm/amdgpu: Reduce mem_type to domain double indirectiondrivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.c+16 -182 replies
3/3drm/amdgpu: Fix pinned GART area accounting and fdinfo reportingdrivers/gpu/drm/amd/amdgpu/amdgpu_object.c+2 -38 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchChristian König
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Some refactoring and maybe a memory accounting fixlet

From: Tvrtko Ursulin <[email protected]>

As I was reading through the driver I spotted one thing which could perhaps make it more readable (1/3), one thing which reduces some double conversions (in principle) from TTM placement back to domain (2/3), and also enables the last patch in the series which maybe fixes a small memory accounting issue. But only relevant when interacting with KFD IIUC.

Assuming the fix is real and not my confusion, please let me know if it is all acceptable, or you would like me to re-structure the series to only contain the fix and break off the rest for later (or never).

Tvrtko Ursulin (3):
drm/amdgpu: Add amdgpu_bo_is_vm_bo helper
drm/amdgpu: Reduce mem_type to domain double indirection drm/amdgpu: Fix pinned GART area accounting and fdinfo reporting

 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c |  4 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c     |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c  | 31 ++++++++++-----------
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h  | 14 ++++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      | 31 +++++++++------------
 5 files changed, 44 insertions(+), 38 deletions(-)
Signature · 1 line
2.44.0