Skip to content

virtio-net: Convert feature properties to OnOffAuto

Akihiko Odaki qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected] change-id 20240428-auto-be0dc010dda5

Versions newest first

  1. v4 Latest2 patches 2 repliesIn review
  2. v35 patches 4 repliesSuperseded
  3. v24 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches7 repliesSuperseded

Changes in v4 from the cover letter

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-net: Convert feature properties to OnOffAutohw/core/machine.c hw/net/virtio-net.c include/hw/virtio/virtio-net.h+169 -962 replies
2/2virtio-net: Report RSS warning at device realizationhw/net/virtio-net.c+4 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] virtio-net: Convert feature properties to OnOffAuto

Based-on: <[email protected]> ("[PATCH v3 0/3] virtio: Convert feature properties to OnOffAuto")

Some features are not always available, and virtio-net used to disable them when not available even if the corresponding properties were explicitly set to "on".

Convert feature properties to OnOffAuto so that the user can explicitly tell QEMU to automatically select the value by setting them "auto". QEMU will give an error if they are set "on".

---
Changes in v4:
- Rebased.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Added patch "qdev-properties: Accept bool for OnOffAuto".
(Michael S. Tsirkin and Daniel P. Berrangé)
- Changed to report errors with ebpf-rss-fds (Daniel P. Berrangé)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Added patch "virtio-net: Remove fallback from ebpf-rss-fds".
- Added a compatibility property.
- Corrected property type name.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Akihiko Odaki (2):
virtio-net: Convert feature properties to OnOffAuto
virtio-net: Report RSS warning at device realization

 include/hw/virtio/virtio-net.h |   3 +-
 hw/core/machine.c              |   1 +
 hw/net/virtio-net.c            | 273 +++++++++++++++++++++++++----------------
 3 files changed, 173 insertions(+), 104 deletions(-)

---
base-commit: d4ce41e114a1f079b0994b1e6aa7f01e20ba490d
change-id: 20240428-auto-be0dc010dda5

Best regards,

Signature · 1 line
Akihiko Odaki <[email protected]>