Skip to content

PCI: Add generic Conf Type 0/1 helpers

Ilpo Järvinen linux-arm-kernel linux-mediatek linux-pci linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ARM: orion5x: Rename PCI_CONF_{REG,FUNC}() out of the wayarch/arm/mach-orion5x/pci.c+6 -64 replies
2/10PCI: Add helpers to calculate PCI Conf Type 0/1 addressesdrivers/pci/pci.h include/linux/pci.h+88 -403 replies
3/10ARM: orion5x: Pass devfn to orion5x_pci_hw_{rd,wr}_conf()arch/arm/mach-orion5x/pci.c+23 -222 replies
4/10ARM: orion5x: Use generic PCI Conf Type 1 helperarch/arm/mach-orion5x/pci.c+2 -151 reply
5/10PCI: ixp4xx: Use generic PCI Conf Type 0 helperdrivers/pci/controller/pci-ixp4xx.c+2 -21 reply
6/10PCI: ixp4xx: Replace 1 with PCI_CONF1_TRANSACTIONdrivers/pci/controller/pci-ixp4xx.c include/linux/pci.h+2 -11 reply
7/10PCI: Replace PCI_CONF1{,_EXT}_ADDRESS() with the new helpersdrivers/pci/controller/pci-ftpci100.c drivers/pci/controller/pci-ixp4xx.c drivers/pci/controller/pcie-mt7621.c +1 more+7 -192 replies
8/10PCI: tegra: Use generic PCI Conf Type 1 helperdrivers/pci/controller/pci-tegra.c+2 -100 replies
9/10PCI: mvebu: Use generic PCI Conf Type 1 helperdrivers/pci/controller/pci-mvebu.c+2 -112 replies
10/10PCI: v3: Use generic PCI Conf Type 0/1 helpersdrivers/pci/controller/pci-v3-semi.c+3 -31 reply

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchAndrew LunnLinus WalleijSergio ParacuellosGregory CLEMENT
1/10R-b A-b
2/10
3/10R-b A-b
4/10A-b
5/10R-b
6/10R-b
7/10R-b A-b T-b
8/10
9/10T-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/10] PCI: Add generic Conf Type 0/1 helpers

This series replaces PCI_CONF1{,_EXT}_ADDRESS() with more generic helpers and makes them more widely available by placing the new helpers into include/linux/pci.h.

Most of what is under drivers/pci/controller is converted to use the new helpers by this series. I left arch/ changes out from this because they're quite varied so they would be harder to verify (and review) except ARM/orion5x that I had to do now due to a naming conflict. Nonetheless, there is plenty custom type 0/1 code under arch/ that could now take advantage of the new helpers.

I've postponed touching pcie-mediatek.c because there's odd slot calculation which I brought up in another thread.

Ilpo Järvinen (10):
ARM: orion5x: Rename PCI_CONF_{REG,FUNC}() out of the way
PCI: Add helpers to calculate PCI Conf Type 0/1 addresses
ARM: orion5x: Pass devfn to orion5x_pci_hw_{rd,wr}_conf()
ARM: orion5x: Use generic PCI Conf Type 1 helper
PCI: ixp4xx: Use generic PCI Conf Type 0 helper
PCI: ixp4xx: Replace 1 with PCI_CONF1_TRANSACTION
PCI: Replace PCI_CONF1{,_EXT}_ADDRESS() with the new helpers
PCI: tegra: Use generic PCI Conf Type 1 helper
PCI: mvebu: Use generic PCI Conf Type 1 helper
PCI: v3: Use generic PCI Conf Type 0/1 helpers

 arch/arm/mach-orion5x/pci.c           | 54 +++++++----------
 drivers/pci/controller/pci-ftpci100.c |  6 +-
 drivers/pci/controller/pci-ixp4xx.c   |  9 ++-
 drivers/pci/controller/pci-mvebu.c    | 13 +---
 drivers/pci/controller/pci-tegra.c    | 12 +---
 drivers/pci/controller/pci-v3-semi.c  |  6 +-
 drivers/pci/controller/pcie-mt7621.c  |  7 +--
 drivers/pci/pci.h                     | 45 --------------
 include/linux/pci.h                   | 86 +++++++++++++++++++++++++++
 9 files changed, 123 insertions(+), 115 deletions(-)
Signature · 1 line
2.39.2