Skip to content

livepatch-build-tools: some bug fixes and improvements

Roger Pau Monne xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9livepatch-build-tools: allow patch file name sizes up to 127 characterslivepatch-build+3 -20 replies
2/9create-diff-object: update default alt_instr sizecreate-diff-object.c+1 -10 replies
3/9livepatch-build: fix detection of structure sizeslivepatch-build+7 -01 reply
4/9create-diff-object: document kpatch_regenerate_special_section() behaviorcreate-diff-object.c+33 -00 replies
5/9create-diff-object: move kpatch_include_symbol()create-diff-object.c+37 -370 replies
6/9create-diff-object: detect changes in .altinstr_replacement and .fixup sectionscreate-diff-object.c+27 -20 replies
7/9create-diff-object: don't account for changes to .bug_frame.? sectionscreate-diff-object.c+11 -00 replies
8/9create-diff-object: account for changes in the special section itselfcreate-diff-object.c+26 -70 replies
9/9create-diff-object: account for special section changescreate-diff-object.c+24 -00 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchRoss Lagerwall
1/9
2/9
3/9R-b
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] livepatch-build-tools: some bug fixes and improvements

Hello,

The first 3 patches in the series attempt to fix some bugs, I don't think they will be specially controversial or difficult to review (patch 1 was already posted standalone).

The rest of the patches are more convoluted, as they attempt to solve some shortcomings when attempting to create livepatches that change alternatives or exceptions. For example a patch that only changes content in alternative blocks (the code that ends up in the .altinstr_replacement section) won't work, as create-diff-object will report that there are no changes.

I've attempted to test as many corner cases as I could come up with, but it's hard to figure all the possible changes, plus it's also fairly easy to inadvertently regress existing functionality.

Thanks, Roger.

Roger Pau Monne (9):
livepatch-build-tools: allow patch file name sizes up to 127
characters
create-diff-object: update default alt_instr size
livepatch-build: fix detection of structure sizes
create-diff-object: document kpatch_regenerate_special_section()
behavior
create-diff-object: move kpatch_include_symbol()
create-diff-object: detect changes in .altinstr_replacement and .fixup
sections
create-diff-object: don't account for changes to .bug_frame.? sections
create-diff-object: account for changes in the special section itself
create-diff-object: account for special section changes

 create-diff-object.c | 196 +++++++++++++++++++++++++++++++++----------
 livepatch-build      |  12 ++-
 2 files changed, 161 insertions(+), 47 deletions(-)
Signature · 1 line
2.44.0