Skip to content

HID: i2c-hid: Unify device wake-up logic

Kenny Levinsen linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2HID: i2c-hid: Retry address probe after delaydrivers/hid/i2c-hid/i2c-hid-core.c+19 -20 replies
2/2HID: i2c-hid: Use address probe to wake on resumedrivers/hid/i2c-hid/i2c-hid-core.c+8 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] HID: i2c-hid: Unify device wake-up logic

Third time was not the charm[0]. After Dmitry's comment[1], and after looking some more at the I2C drivers, I have given up on removing the smbus probe for now. We can always revisit this later if the situation improves enough, but there are more important things to fix.

Instead, go all in on the address probe with retry and use it for both initial probe and resume, replacing the previous retry on power on commands. This gives us consistency and a single place to update and document.

[0]: https://lore.kernel.org/all/[email protected]/
[1]: https://lore.kernel.org/all/[email protected]/