Skip to content

slimbus: use 'time_left' instead of 'timeout' with wait_for_*() functions

Wolfram Sang alsa-devel linux-arm-msm 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3slimbus: messaging: use 'time_left' variable with wait_for_completion_timeout()drivers/slimbus/messaging.c+5 -40 replies
2/3slimbus: qcom-ctrl: use 'time_left' variable with wait_for_completion_timeout()drivers/slimbus/qcom-ctrl.c+4 -30 replies
3/3slimbus: qcom-ngd-ctrl: use 'time_left' variable with wait_for_completion_timeout()drivers/slimbus/qcom-ngd-ctrl.c+16 -130 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBjorn Andersson
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] slimbus: use 'time_left' instead of 'timeout' with wait_for_*() functions

There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_for_*() functions causing patterns like:

timeout = wait_for_completion_timeout(...) if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code obvious and self explaining.

This is part of a tree-wide series. The rest of the patches can be found here (some parts may still be WIP):

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left

Because these patches are generated, I audit them before sending. This is why I will send series step by step. Build bot is happy with these patches, though. No functional changes intended.

Wolfram Sang (3):
slimbus: messaging: use 'time_left' variable with
wait_for_completion_timeout()
slimbus: qcom-ctrl: use 'time_left' variable with
wait_for_completion_timeout()
slimbus: qcom-ngd-ctrl: use 'time_left' variable with
wait_for_completion_timeout()

 drivers/slimbus/messaging.c     |  9 +++++----
 drivers/slimbus/qcom-ctrl.c     |  7 ++++---
 drivers/slimbus/qcom-ngd-ctrl.c | 29 ++++++++++++++++-------------
 3 files changed, 25 insertions(+), 20 deletions(-)
Signature · 1 line
2.43.0