target/sh4: Fix ADDV/SUBV opcodes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 5 repliesIn review
- v34 patches 1 replySuperseded
- v21 patch 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 1 patch | 3 replies | Superseded |
Changes in v4 from the cover letter
- Fixed copy/paste mistake (Paul)
- Tests print values on failure
- Added rth R-b tags
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | target/sh4: Fix ADDV opcodetarget/ tests/ tests/ | +31 | 1 reply | |
| 2/4 | target/sh4: Fix SUBV opcodetarget/ tests/ tests/ | +34 | 1 reply | |
| 3/4 | target/sh4: Rename TCGv variables as manual for ADDV opcodetarget/ | +10 | 1 reply | |
| 4/4 | target/sh4: Rename TCGv variables as manual for SUBV opcodetarget/ | +10 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Yoshinori Sato |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | R-b |
| 3/4 | R-b | R-b |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] target/sh4: Fix ADDV/SUBV opcodes
Pass 'build-legacy' CI job which runs check-tcg-sh4.
Since v3:
- Fixed copy/paste mistake (Paul)
- Tests print values on failure
- Added rth R-b tags
Since v2:
- Add tests (Paul)
- Rename TCGv variables as in manual
Philippe Mathieu-Daudé (4):
target/sh4: Fix ADDV opcode
target/sh4: Fix SUBV opcode
target/sh4: Rename TCGv variables as manual for ADDV opcode target/sh4: Rename TCGv variables as manual for SUBV opcode
target/sh4/translate.c | 32 ++++++++++++++++++++------------ tests/tcg/sh4/test-addv.c | 27 +++++++++++++++++++++++++++ tests/tcg/sh4/test-subv.c | 30 ++++++++++++++++++++++++++++++ tests/tcg/sh4/Makefile.target | 6 ++++++ 4 files changed, 83 insertions(+), 12 deletions(-) create mode 100644 tests/tcg/sh4/test-addv.c create mode 100644 tests/tcg/sh4/test-subv.c
Signature · 1 line
2.41.0