Skip to content

Enable display support for Battlemage

Radhakrishna Sripada intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest19 patches 5 repliesIn review

Changes in v3 from the cover letter

* use s/XE_LPDP_FEATURES/XE_LPD_FEATURE as base for BMG display info structure
* Limit "BW Credits" programming only to xelpdp
* Removed UHBR20 support
* Commit description improved for patch - "Skip CCS modifiers for Xe2 platforms"
* Still retained the patch "Enable RM timeout detection" in this series hoping there are no further comments and could be merged with this series.
* Removed the check where RM timeout interrupt was enabled only for xe2hpd
* Redesigned how the right C20 PHY offsets are selected for different display IP versions

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/i915/bmg: Lane reversal requires writes to both context lanesdrivers/gpu/drm/i915/display/intel_cx0_phy.c+5 -50 replies
2/19drm/i915/bmg: Define IS_BATTLEMAGE macrodrivers/gpu/drm/i915/i915_drv.h+9 -10 replies
3/19drm/i915/xe2hpd: Initial cdclk tabledrivers/gpu/drm/i915/display/intel_cdclk.c+11 -00 replies
4/19drm/i915/bmg: Extend DG2 tc check to futuredrivers/gpu/drm/i915/display/intel_display.c+3 -40 replies
5/19drm/i915/xe2hpd: Properly disable power in port Adrivers/gpu/drm/i915/display/intel_cx0_phy.c+14 -30 replies
6/19drm/i915/xe2hpd: Add new C20 PHY SRAM addressdrivers/gpu/drm/i915/display/intel_cx0_phy.c drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h+81 -321 reply
7/19drm/i915/xe2hpd: Add support for eDP PLL configurationdrivers/gpu/drm/i915/display/intel_cx0_phy.c+146 -10 replies
8/19drm/i915/xe2hpd: update pll values in sync with Bspecdrivers/gpu/drm/i915/display/intel_cx0_phy.c+44 -20 replies
9/19drm/i915/xe2hpd: Add display infodrivers/gpu/drm/i915/display/intel_display_device.c+7 -00 replies
10/19drm/i915/xe2hpd: Configure CHICKEN_MISC_2 before enabling planesdrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/i915_reg.h+5 -00 replies
11/19drm/i915/xe2hpd: Add max memory bandwidth algorithmdrivers/gpu/drm/i915/display/intel_bw.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/soc/intel_dram.c +1 more+69 -20 replies
12/19drm/i915/xe2hpd: Do not program MBUS_DBOX BW creditsdrivers/gpu/drm/i915/display/skl_watermark.c+1 -10 replies
13/19drm/i915/bmg: BMG should re-use MTL's south display logicdrivers/gpu/drm/i915/soc/intel_pch.c+2 -20 replies
14/19Revert "drm/i915/dgfx: DGFX uses direct VBT pin mapping"drivers/gpu/drm/i915/display/intel_bios.c+2 -30 replies
15/19drm/i915/xe2hpd: Set maximum DP rate to UHBR13.5drivers/gpu/drm/i915/display/intel_dp.c+3 -00 replies
16/19drm/xe/gt_print: add xe_gt_err_once()drivers/gpu/drm/xe/xe_gt_printk.h+3 -01 reply
17/19drm/xe/device: implement transient flushdrivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device.h+53 -01 reply
18/19drm/i915/display: perform transient flushdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_frontbuffer.c drivers/gpu/drm/i915/display/intel_tdf.h +2 more+45 -11 reply
19/19drm/xe/bmg: Enable the display supportdrivers/gpu/drm/xe/xe_pci.c+1 -01 reply

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by.

PatchMatt RoperNirmoy DasRadhakrishna SripadaDnyaneshwar BhadaneShekhar ChauhanLucas De Marchi
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b A-b
17/19R-b A-b
18/19R-b A-b
19/19R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/19] Enable display support for Battlemage

Adds display support for Battlemage.

v4:
* Dropped patch "drm/i915/xe2hpd: Skip CCS modifiers" as there is already a patch merged taking care of this fix.
* Dropped patch "drm/i915/display: Enable RM timeout detection" as it is not really a BMG enablement patch. Will be posted as a separate series.
* Macros renamed and rearranged to match the existing style in the file for patch "Add new C20 PHY SRAM address"

v3:
* use s/XE_LPDP_FEATURES/XE_LPD_FEATURE as base for BMG display info structure
* Limit "BW Credits" programming only to xelpdp
* Removed UHBR20 support
* Commit description improved for patch - "Skip CCS modifiers for Xe2 platforms"
* Still retained the patch "Enable RM timeout detection" in this series hoping there are no further comments and could be merged with this series.
* Removed the check where RM timeout interrupt was enabled only for xe2hpd
* Redesigned how the right C20 PHY offsets are selected for different display IP versions

v2: Rebased on latest drm-tip
v3: Rebase and fix a white space error(RK)

Ankit Nautiyal (1):
Revert "drm/i915/dgfx: DGFX uses direct VBT pin mapping"

Anusha Srivatsa (1):
drm/i915/xe2hpd: Configure CHICKEN_MISC_2 before enabling planes

Balasubramani Vivekanandan (5):
drm/i915/bmg: Define IS_BATTLEMAGE macro drm/i915/xe2hpd: Add new C20 PHY SRAM address drm/i915/xe2hpd: Add support for eDP PLL configuration drm/i915/xe2hpd: Set maximum DP rate to UHBR13.5 drm/xe/bmg: Enable the display support

Clint Taylor (2):
drm/i915/bmg: Lane reversal requires writes to both context lanes drm/i915/xe2hpd: Initial cdclk table

José Roberto de Souza (2):
drm/i915/xe2hpd: Properly disable power in port A drm/i915/xe2hpd: Do not program MBUS_DBOX BW credits

Lucas De Marchi (1):
drm/i915/xe2hpd: Add display info

Matt Roper (2):
drm/i915/xe2hpd: Add max memory bandwidth algorithm drm/i915/bmg: BMG should re-use MTL's south display logic

Matthew Auld (2):
drm/xe/gt_print: add xe_gt_err_once()
drm/i915/display: perform transient flush

Nirmoy Das (1):
drm/xe/device: implement transient flush

Radhakrishna Sripada (1):
drm/i915/bmg: Extend DG2 tc check to future

Ravi Kumar Vodapalli (1):
drm/i915/xe2hpd: update pll values in sync with Bspec

 drivers/gpu/drm/i915/display/intel_bios.c     |   5 +-
 drivers/gpu/drm/i915/display/intel_bw.c       |  65 +++-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  11 +
 drivers/gpu/drm/i915/display/intel_cx0_phy.c  | 285 +++++++++++++++---
 .../gpu/drm/i915/display/intel_cx0_phy_regs.h |  48 ++-
 drivers/gpu/drm/i915/display/intel_display.c  |  10 +-
 .../drm/i915/display/intel_display_device.c   |   7 +
 .../drm/i915/display/intel_display_power.c    |   4 +
 drivers/gpu/drm/i915/display/intel_dp.c       |   3 +
 .../gpu/drm/i915/display/intel_frontbuffer.c  |   2 +
 drivers/gpu/drm/i915/display/intel_tdf.h      |  25 ++
 drivers/gpu/drm/i915/display/skl_watermark.c  |   2 +-
 drivers/gpu/drm/i915/i915_drv.h               |  11 +-
 drivers/gpu/drm/i915/i915_reg.h               |   1 +
 drivers/gpu/drm/i915/soc/intel_dram.c         |   4 +
 drivers/gpu/drm/i915/soc/intel_pch.c          |   4 +-
 drivers/gpu/drm/xe/Makefile                   |   3 +-
 drivers/gpu/drm/xe/display/xe_tdf.c           |  13 +
 drivers/gpu/drm/xe/regs/xe_gt_regs.h          |   3 +
 drivers/gpu/drm/xe/xe_device.c                |  49 +++
 drivers/gpu/drm/xe/xe_device.h                |   1 +
 drivers/gpu/drm/xe/xe_device_types.h          |   1 +
 drivers/gpu/drm/xe/xe_gt_printk.h             |   3 +
 drivers/gpu/drm/xe/xe_pci.c                   |   1 +
 24 files changed, 504 insertions(+), 57 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_tdf.h
 create mode 100644 drivers/gpu/drm/xe/display/xe_tdf.c
Signature · 1 line
2.34.1