Skip to content

perf/core: Check sample_type in sample data saving helper functions

Yabin Cui bpf linux-perf-users lkml 5 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 4 repliesApplied
  2. v43 patches 9 repliesSuperseded
  3. v3 posting 2/23 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v3 posting 1/23 patches0 repliesSuperseded
v21 patch3 repliesSuperseded

Changes in v5 from the cover letter

- Give a warning if data->sample_flags is already set when calling the helper functions.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3perf/core: Save raw sample data conditionally based on sample typearch/s390/kernel/perf_cpum_cf.c arch/s390/kernel/perf_pai_crypto.c arch/s390/kernel/perf_pai_ext.c +4 more+34 -260 replies
2/3perf/core: Check sample_type in perf_sample_save_callchainarch/x86/events/amd/ibs.c arch/x86/events/intel/ds.c include/linux/perf_event.h+8 -60 replies
3/3perf/core: Check sample_type in perf_sample_save_brstackarch/x86/events/amd/core.c arch/x86/events/core.c arch/x86/events/intel/ds.c +1 more+13 -110 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamhyung Kim
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] perf/core: Check sample_type in sample data saving helper functions

Hello,

We use helper functions to save raw data, callchain and branch stack in perf_sample_data. These functions update perf_sample_data->dyn_size without checking event->attr.sample_type, which may result in unused space allocated in sample records. To prevent this from happening, this patchset enforces checking sample_type of an event in these helper functions.

Thanks,
Yabin

Changes since v1:
- Check event->attr.sample_type & PERF_SAMPLE_RAW before calling perf_sample_save_raw_data().
- Subject has been changed to reflect the change of solution.

Changes since v2:
- Move sample_type check into perf_sample_save_raw_data().
- (New patch) Move sample_type check into perf_sample_save_callchain().
- (New patch) Move sample_type check into perf_sample_save_brstack().

Changes since v3:
- Fix -Werror=implicit-function-declaration by moving has_branch_stack().

Changes since v4:
- Give a warning if data->sample_flags is already set when calling the helper functions.

Original commit message from v1:
perf/core: Trim dyn_size if raw data is absent

Original commit message from v2/v3:
perf/core: Save raw sample data conditionally based on sample type

Yabin Cui (3):
perf/core: Save raw sample data conditionally based on sample type perf/core: Check sample_type in perf_sample_save_callchain perf/core: Check sample_type in perf_sample_save_brstack

 arch/s390/kernel/perf_cpum_cf.c    |  2 +-
 arch/s390/kernel/perf_pai_crypto.c |  2 +-
 arch/s390/kernel/perf_pai_ext.c    |  2 +-
 arch/x86/events/amd/core.c         |  3 +--
 arch/x86/events/amd/ibs.c          |  5 ++---
 arch/x86/events/core.c             |  3 +--
 arch/x86/events/intel/ds.c         |  9 +++-----
 include/linux/perf_event.h         | 26 +++++++++++++++++-----
 kernel/events/core.c               | 35 +++++++++++++++---------------
 kernel/trace/bpf_trace.c           | 11 +++++-----
 10 files changed, 55 insertions(+), 43 deletions(-)
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog