Skip to content

perf annotate-data: Small updates in the data type profiling (v1)

Namhyung Kim linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6perf dwarf-aux: Add die_collect_global_vars()tools/perf/util/dwarf-aux.c tools/perf/util/dwarf-aux.h+70 -00 replies
2/6perf annotate-data: Collect global variables in advancetools/perf/util/annotate-data.c+55 -23 replies
3/6perf annotate-data: Handle direct global variable accesstools/perf/util/annotate-data.c+15 -120 replies
4/6perf annotate-data: Check memory access with two registerstools/perf/util/annotate-data.c+39 -53 replies
5/6perf annotate-data: Handle multi regs in find_data_type_block()tools/perf/util/annotate-data.c+12 -110 replies
6/6perf annotate-data: Check kind of stack variablestools/perf/util/annotate-data.c+6 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/6] perf annotate-data: Small updates in the data type profiling (v1)

Hello,

This is a mix of bug fixes and optimization in the data type profiling.

Firstly it now caches global variables and looks them up by address later. This will be good for performance as well as improves the success rates because some variables are defined in a separate file (compile unit) and has no info in the call site for some reason.

Also it properly checks instructions that use more than one register for a memory access like x86 SIB addressing. And check the type of stack variables correctly and discard constant values (without type info).

Thanks,
Namhyung

Namhyung Kim (6):
perf dwarf-aux: Add die_collect_global_vars()
perf annotate-data: Collect global variables in advance perf annotate-data: Handle direct global variable access perf annotate-data: Check memory access with two registers perf annotate-data: Handle multi regs in find_data_type_block() perf annotate-data: Check kind of stack variables

 tools/perf/util/annotate-data.c | 157 ++++++++++++++++++++++++++------
 tools/perf/util/dwarf-aux.c     |  62 +++++++++++++
 tools/perf/util/dwarf-aux.h     |   8 ++
 3 files changed, 197 insertions(+), 30 deletions(-)
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog