Skip to content

selftests: mm: cow: flag vmsplice() hugetlb tests as XFAIL

David Hildenbrand linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] mm-hugetlb-document-why-hugetlb-uses-folio_mapcount-for-cow-reuse-decisions.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests: mm: cow: flag vmsplice() hugetlb tests as XFAILtools/testing/selftests/mm/cow.c+71 -350 repliesApplied
2/2mm/hugetlb: document why hugetlb uses folio_mapcount() for COW reuse decisionsmm/hugetlb.c+7 -02 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] selftests: mm: cow: flag vmsplice() hugetlb tests as XFAIL

The failing hugetlb vmsplice() COW tests keep confusing people, and having tests that have been failing for years and likely will keep failing for years to come because nobody cares enough is rather suboptimal. Let's mark them as XFAIL and document why fixing them is not that easy as it would appear at first sight.

More details can be found in [1], especially around how hugetlb pages cannot really be overcommitted, and why we don't particularly care about these vmsplice() leaks for hugetlb -- in contrast to ordinary memory.

[1] https://lore.kernel.org/all/[email protected]/

Cc Andrew Morton <[email protected]>
Cc Muchun Song <[email protected]>
Cc Shuah Khan <[email protected]>

David Hildenbrand (2):
selftests: mm: cow: flag vmsplice() hugetlb tests as XFAIL mm/hugetlb: document why hugetlb uses folio_mapcount() for COW reuse
decisions

 mm/hugetlb.c                     |   7 ++
 tools/testing/selftests/mm/cow.c | 106 +++++++++++++++++++++----------
 2 files changed, 78 insertions(+), 35 deletions(-)
Signature · 1 line
2.44.0