Skip to content

selftests/futex: clang-inspired fixes

John Hubbard linux-kselftest lkml llvm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 11 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

Changes in v3 from the cover letter

1) Added a sentence to the .PHONY patch, to show that it is removing duplicate code.

2) Added the actual clang warning output to the commit description.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests/futex: don't redefine .PHONY targets (all, clean)tools/testing/selftests/futex/Makefile+0 -20 replies
2/3selftests/futex: don't pass a const char* to asprintf(3)tools/testing/selftests/futex/functional/futex_requeue_pi.c+1 -10 replies
3/3selftests/futex: pass _GNU_SOURCE without a value to the compilertools/testing/selftests/futex/functional/Makefile+1 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDavidlohr BuesoEdward Liaw
1/3R-b
2/3R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] selftests/futex: clang-inspired fixes

Hi,

Here's a few fixes that are part of my effort to get all selftests building cleanly under clang. Plus one that I noticed by inspection.

Changes since v2:

1) Added a sentence to the .PHONY patch, to show that it is removing duplicate code.

2) Added the actual clang warning output to the commit description.

Changes since the first version:

1) Rebased onto Linux 6.10-rc1
2) Added Reviewed-by's.

...and it turns out that all three patches are still required, on -rc1, in order to get a clean clang build.

Enjoy!

thanks,
John Hubbard

John Hubbard (3):
selftests/futex: don't redefine .PHONY targets (all, clean) selftests/futex: don't pass a const char* to asprintf(3) selftests/futex: pass _GNU_SOURCE without a value to the compiler

 tools/testing/selftests/futex/Makefile                      | 2 --
 tools/testing/selftests/futex/functional/Makefile           | 2 +-
 tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

base-commit: b050496579632f86ee1ef7e7501906db579f3457

Signature · 1 line
2.45.1