RFC xfs: fallocate RT flush unmap range fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | xfs: Fix xfs_flush_unmap_range() range for RTfs/ | +6 | 4 replies | |
| 2/2 | xfs: Fix xfs_prepare_shift() range for RTfs/ | +6 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH RFC 0/2] xfs: fallocate RT flush unmap range fixes
As mentioned by Dave Chinner at [0], xfs_flush_unmap_range() and xfs_prepare_shift() should consider RT extents in the flush unmap range, and need to be fixed.
I don't want to add such changes to that series, so I am sending separately.
I am marking as an RFC as I am not intimately familiar enough with the code for me to say that the changes are technically correct.
About the change in xfs_prepare_shift(), that function is only called from xfs_insert_file_space() and xfs_collapse_file_space(). Those functions only permit RT extent-aligned calls in xfs_is_falloc_aligned(), so in practice I don't think that this change would affect xfs_prepare_shift(). And xfs_prepare_shift() calls xfs_flush_unmap_range(), which is being fixed up anyway.
[0] https://lore.kernel.org/linux-xfs/[email protected]/
John Garry (2):
xfs: Fix xfs_flush_unmap_range() range for RT
xfs: Fix xfs_prepare_shift() range for RT
fs/xfs/xfs_bmap_util.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
Signature · 1 line
2.31.1