Skip to content

gve: Add flow steering support

Ziwei Xiao lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 2 repliesSuperseded
  3. v15 patches 16 repliesSuperseded

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5gve: Add adminq mutex lockdrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_adminq.c+13 -100 repliesApplied
2/5gve: Add adminq extended commanddrivers/net/ethernet/google/gve/gve_adminq.c drivers/net/ethernet/google/gve/gve_adminq.h+43 -00 repliesApplied
3/5gve: Add flow steering device optiondrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_adminq.c drivers/net/ethernet/google/gve/gve_adminq.h+51 -20 repliesApplied
4/5gve: Add flow steering adminq commandsdrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_adminq.c drivers/net/ethernet/google/gve/gve_adminq.h +2 more+314 -40 repliesApplied
5/5gve: Add flow steering ethtool supportdrivers/net/ethernet/google/gve/Makefile drivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_ethtool.c +2 more+398 -90 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPraveen KaligineediHarshitha RamamurthyWillem de Bruijn
1/5R-b R-b R-b
2/5R-b R-b R-b
3/5R-b R-b R-b
4/5R-b R-b R-b
5/5R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 0/5] gve: Add flow steering support

To support flow steering in GVE driver, there are two adminq changes need to be made in advance.

The first one is adding adminq mutex lock, which is to allow the incoming flow steering operations to be able to temporarily drop the rtnl_lock to reduce the latency for registering flow rules among several NICs at the same time. This could be achieved by the future changes to reduce the drivers' dependencies on the rtnl lock for particular ethtool ops.

The second one is to add the extended adminq command so that we can support larger adminq command such as configure_flow_rule command. In that patch, there is a new added function called gve_adminq_execute_extended_cmd with the attribute of __maybe_unused. That attribute will be removed in the third patch of this series where it will use the previously unused function.

And the other three patches are needed for the actual flow steering feature support in driver.

Jeroen de Borst (4):
gve: Add adminq extended command
gve: Add flow steering device option
gve: Add flow steering adminq commands
gve: Add flow steering ethtool support

Ziwei Xiao (1):
gve: Add adminq mutex lock

 drivers/net/ethernet/google/gve/Makefile      |   2 +-
 drivers/net/ethernet/google/gve/gve.h         |  54 +++-
 drivers/net/ethernet/google/gve/gve_adminq.c  | 228 +++++++++++++-
 drivers/net/ethernet/google/gve/gve_adminq.h  | 103 ++++++
 drivers/net/ethernet/google/gve/gve_ethtool.c |  72 ++++-
 .../net/ethernet/google/gve/gve_flow_rule.c   | 298 ++++++++++++++++++
 drivers/net/ethernet/google/gve/gve_main.c    |  83 ++++-
 7 files changed, 817 insertions(+), 23 deletions(-)
 create mode 100644 drivers/net/ethernet/google/gve/gve_flow_rule.c
Signature · 1 line
2.45.2.741.gdbec12cfda-goog