Skip to content

bpf: make trusted args nullable

Vadim Fedorenko bpf 3 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v24 patches 10 repliesSuperseded
  3. v14 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- add special selftest for nullable parameters

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5bpf: verifier: make kfuncs args nullalblekernel/bpf/verifier.c+3 -30 repliesApplied
2/5bpf: crypto: make state and IV dynptr nullablekernel/bpf/crypto.c+13 -130 repliesApplied
3/5selftests: bpf: crypto: use NULL instead of 0-sized dynptrtools/testing/selftests/bpf/progs/crypto_sanity.c+4 -120 repliesApplied
4/5selftests: bpf: crypto: adjust bench to use nullable IVtools/testing/selftests/bpf/progs/crypto_bench.c+4 -60 repliesApplied
5/5selftests: bpf: add testmod kfunc for nullable paramstools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_kfunc.h tools/testing/selftests/bpf/prog_tests/kfunc_param_nullable.c +1 more+61 -00 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchEduard Zingerman
1/5A-b
2/5R-b
3/5R-b
4/5R-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH RESEND bpf-next v3 0/5] bpf: make trusted args nullable

Current verifier checks for the arg to be nullable after checking for certain pointer types. It prevents programs to pass NULL to kfunc args even if they are marked as nullable. This patchset adjusts verifier and changes bpf crypto kfuncs to allow null for IV parameter which is optional for some ciphers. Benchmark shows ~4% improvements when there is no need to initialise 0-sized dynptr.

v3:
- add special selftest for nullable parameters
v2:
- adjust kdoc accordingly

Vadim Fedorenko (5):
bpf: verifier: make kfuncs args nullalble
bpf: crypto: make state and IV dynptr nullable
selftests: bpf: crypto: use NULL instead of 0-sized dynptr
selftests: bpf: crypto: adjust bench to use nullable IV
selftests: bpf: add testmod kfunc for nullable params

 kernel/bpf/crypto.c                           | 26 +++++------
 kernel/bpf/verifier.c                         |  6 +--
 .../selftests/bpf/bpf_testmod/bpf_testmod.c   |  6 +++
 .../bpf/bpf_testmod/bpf_testmod_kfunc.h       |  1 +
 .../bpf/prog_tests/kfunc_param_nullable.c     | 11 +++++
 .../selftests/bpf/progs/crypto_bench.c        | 10 ++---
 .../selftests/bpf/progs/crypto_sanity.c       | 16 ++-----
 .../bpf/progs/test_kfunc_param_nullable.c     | 43 +++++++++++++++++++
 8 files changed, 85 insertions(+), 34 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/kfunc_param_nullable.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_kfunc_param_nullable.c
Signature · 1 line
2.43.0