Skip to content

drm/i915/dp_mst: Enable link training fallback

Imre Deak intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest21 patches 2 repliesIn review
  2. v221 patches 31 repliesSuperseded
  3. v120 patches 6 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPsdrivers/gpu/drm/i915/display/intel_dp_mst.c+23 -40 replies
2/21drm/i915/dp: Move link train params to a substruct in intel_dpdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c+23 -200 replies
3/21drm/i915/dp: Move link train fallback to intel_dp_link_training.cdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_link_training.c+77 -760 replies
4/21drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()drivers/gpu/drm/i915/display/intel_dp_link_training.c+56 -360 replies
5/21drm/i915: Factor out function to modeset commit a set of pipesdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+38 -300 replies
6/21drm/i915/dp: Use a commit modeset for link retraining MST linksdrivers/gpu/drm/i915/display/intel_dp.c+19 -60 replies
7/21drm/i915/dp: Recheck link state after modesetdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/g4x_dp.c drivers/gpu/drm/i915/display/intel_ddi.c +7 more+124 -51 reply
8/21drm/i915/dp: Reduce link params only after retrying with unchanged paramsdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_training.c+14 -00 replies
9/21drm/i915/dp: Pass atomic state to link training functiondrivers/gpu/drm/i915/display/g4x_dp.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dp.c +2 more+18 -70 replies
10/21drm/i915/dp: Send a link training modeset-retry uevent to all MST connectorsdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_link_training.c+18 -60 replies
11/21drm/i915/dp: Use check link state work in the hotplug handlerdrivers/gpu/drm/i915/display/g4x_dp.c drivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_dp.c +1 more+21 -250 replies
12/21drm/i915/dp: Use check link state work in the detect handlerdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h+8 -90 replies
13/21drm/i915/dp: Use check link state work in the HPD IRQ handlerdrivers/gpu/drm/i915/display/intel_dp.c+7 -40 replies
14/21drm/i915/dp: Disable link retraining after the last fallback stepdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_training.c+18 -80 replies
15/21drm/i915/dp_mst: Reset intel_dp->link_trained during disablingdrivers/gpu/drm/i915/display/intel_dp_mst.c+3 -00 replies
16/21drm/i915/dp_mst: Enable link training fallback for MSTdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_training.c+5 -140 replies
17/21drm/i915/dp: Add debugfs entries to force the link rate/lane countdrivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c +3 more+289 -70 replies
18/21drm/i915/dp: Add debugfs entries to get the max link rate/lane countdrivers/gpu/drm/i915/display/intel_dp_link_training.c+44 -00 replies
19/21drm/i915/dp: Add debugfs entry to force link training failuredrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp_link_training.c+54 -20 replies
20/21drm/i915/dp: Add debugfs entry to force link retraindrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_link_training.c+59 -50 replies
21/21drm/i915/dp: Add debugfs entry to get the link retrain disabled statedrivers/gpu/drm/i915/display/intel_dp_link_training.c+22 -00 replies

Reviews trailers per patch

5 of 21 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVille Syrjälä
SeriesR-b
1/21R-b
2/21
3/21R-b
4/21R-b
5/21R-b
6/21R-b
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/21] drm/i915/dp_mst: Enable link training fallback

This is v3 of [1], addressing the review comments and adding R-bs from Ville, the main changes being:

- Add the link check work to intel_encoder and the corresponding helper functions to a new intel_encoder.c file. (Patch 7)
- Add documentation/asserts on intel_atomic_state being valid for MST vs. possibly NULL for SST links in the link training functions. (Patch 9,10)
- Lock connection_mutex in the debugfs entries only for the required intel_dp state. (Patch 17-21)
- Remove the link training info debugfs entry showing the link retrain, link training failure counters and the retrain disabled state, add a separate debugfs entry showing only the retrain disabled state. (Patch 21)

[1] https://lore.kernel.org/all/[email protected]

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>

Imre Deak (21):
drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs drm/i915/dp: Move link train params to a substruct in intel_dp drm/i915/dp: Move link train fallback to intel_dp_link_training.c drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() drm/i915: Factor out function to modeset commit a set of pipes drm/i915/dp: Use a commit modeset for link retraining MST links drm/i915/dp: Recheck link state after modeset
drm/i915/dp: Reduce link params only after retrying with unchanged
params
drm/i915/dp: Pass atomic state to link training function drm/i915/dp: Send a link training modeset-retry uevent to all MST
connectors
drm/i915/dp: Use check link state work in the hotplug handler drm/i915/dp: Use check link state work in the detect handler drm/i915/dp: Use check link state work in the HPD IRQ handler drm/i915/dp: Disable link retraining after the last fallback step drm/i915/dp_mst: Reset intel_dp->link_trained during disabling drm/i915/dp_mst: Enable link training fallback for MST drm/i915/dp: Add debugfs entries to force the link rate/lane count drm/i915/dp: Add debugfs entries to get the max link rate/lane count drm/i915/dp: Add debugfs entry to force link training failure drm/i915/dp: Add debugfs entry to force link retrain drm/i915/dp: Add debugfs entry to get the link retrain disabled state

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/g4x_dp.c         |  35 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  67 +--
 drivers/gpu/drm/i915/display/intel_display.c  |  34 ++
 drivers/gpu/drm/i915/display/intel_display.h  |   3 +
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |  25 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 270 +++++----
 drivers/gpu/drm/i915/display/intel_dp.h       |  11 +-
 .../drm/i915/display/intel_dp_link_training.c | 538 +++++++++++++++++-
 .../drm/i915/display/intel_dp_link_training.h |   8 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  30 +-
 drivers/gpu/drm/i915/display/intel_encoder.c  |  39 ++
 drivers/gpu/drm/i915/display/intel_encoder.h  |  16 +
 drivers/gpu/drm/xe/Makefile                   |   1 +
 15 files changed, 878 insertions(+), 202 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.h
Signature · 1 line
2.43.3