pinctrl: rockchip: add rk3308b SoC support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 4 repliesIn review
- v22 patches 1 replySuperseded
- v13 patches 13 repliesSuperseded
Changes in v3 from the cover letter
- Witespace cleanup
- Add Luca's r-b tag
- Rebase onto linux-pinctrl for-next branch
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | pinctrl: rockchip: delay recalced_mask and route_mask initdrivers/ | +32 | 1 reply | |
| 2/2 | pinctrl: rockchip: add rk3308b SoC supportdrivers/ drivers/ | +235 | 3 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Luca Ceresoli |
|---|---|
| 1/2 | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] pinctrl: rockchip: add rk3308b SoC support
This patch series and adds support for pin controller found on rk3308b. According to rk3308b TRM, this pinctrl much the same as rk3308's, but with additional iomux routes and 3bit iomuxes selected via gpio##_sel_src_ctrl registers.
Downstream kernel [1] managed this SoC's with rk3308b_soc_data_init, wich picked configuration based on cpuid. Upstream pinctrl patches droped soc init function.
The function rk3308b_soc_sel_src_init sets up gpio##_sel_src_ctrl registers, making SoC to use 3bit iomuxes over some 2bit old ones.
These patches have been tested on Radxa's ROCK Pi S, one based on rk3308 and the other on rk3308b (from the latest batches). For the new boards it fixes broken spi1 clk.
Similar effort [2] was made several years ago, but without keeping base rk3308 SoC pinctrl support.
Based on feedback from Luca, Heiko and Jonas, the v2 series droped dt binding in the favor of runtime SoC detection, so iomux_recalced and iomux_routes updated for the new SoC's and patch 1 delays recalced_mask and route_mask init.
[1] https://github.com/radxa/kernel/blob/stable-4.4-rockpis/drivers/pinctrl/pinctrl-rockchip.c#L4388
[2] https://lore.kernel.org/linux-rockchip/[email protected]/
v1 Link: https://lore.kernel.org/all/[email protected]/
v2 Link: https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Witespace cleanup
- Add Luca's r-b tag
- Rebase onto linux-pinctrl for-next branch
Changes in v2:
- Drop routes fixup patch, already applied
- Drop dt binding patch
- Add new patch to delay recalced_mask and route_mask init
- Rework last patch from dt to runtime setup with rk3308_soc_data_update
Dmitry Yashin (2):
pinctrl: rockchip: delay recalced_mask and route_mask init
pinctrl: rockchip: add rk3308b SoC support
drivers/pinctrl/pinctrl-rockchip.c | 286 +++++++++++++++++++++++++++-- drivers/pinctrl/pinctrl-rockchip.h | 1 + 2 files changed, 267 insertions(+), 20 deletions(-)
base-commit: 32335efff386d04961b178d4c6b7d1ccbafb729f
Signature · 1 line
2.39.2