Skip to content

target/ppc: vcpu hotplug failure handling fixes

Harsh Prateek Bora qemu-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 0 repliesNew
  2. v33 patches 3 repliesSuperseded
  3. v24 patches 8 repliesSuperseded

Changelog from the cover letter

v4: rebased, comment update in patch 3, added R-bys.
v3: Addressed review comments from Nick
v2: Addressed review comments from Nick
v1: Initial patch

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3accel/kvm: Introduce kvm_create_and_park_vcpu() helperaccel/kvm/kvm-all.c include/sysemu/kvm.h+20 -00 replies
2/3cpu-common.c: export cpu_get_free_index to be reused latercpu-common.c include/exec/cpu-common.h+6 -30 replies
3/3target/ppc: handle vcpu hotplug failure gracefullytarget/ppc/kvm.c+46 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNicholas PigginAnushree Mathur
1/3R-b
2/3R-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] target/ppc: vcpu hotplug failure handling fixes

On ppc64, the PowerVM hypervisor runs with limited memory and a VCPU creation during hotplug may fail during kvm_ioctl for KVM_CREATE_VCPU, leading to termination of guest since errp is set to &error_fatal while calling kvm_init_vcpu. This unexpected behaviour can be avoided by pre-creating and parking vcpu on success or return error otherwise. This enables graceful error delivery for any vcpu hotplug failures while the guest can keep running.

This series adds another helper to create and park vcpu, based on [1], exports cpu_get_free_index to be reused later and adds ppc arch specfic handling for vcpu hotplug failure using kvm accel helper cpu_target_realize.

[1] <[email protected]>

Changelog:
v4: rebased, comment update in patch 3, added R-bys.
v3: Addressed review comments from Nick
v2: Addressed review comments from Nick
v1: Initial patch

Harsh Prateek Bora (3):
accel/kvm: Introduce kvm_create_and_park_vcpu() helper cpu-common.c: export cpu_get_free_index to be reused later target/ppc: handle vcpu hotplug failure gracefully

 include/exec/cpu-common.h |  2 ++
 include/sysemu/kvm.h      |  8 +++++++
 accel/kvm/kvm-all.c       | 12 ++++++++++
 cpu-common.c              |  7 +++---
 target/ppc/kvm.c          | 46 +++++++++++++++++++++++++++++++++++++++
 5 files changed, 72 insertions(+), 3 deletions(-)
Signature · 1 line
2.45.1