Skip to content

improve -overcommit cpu-pm=on|off

Zide Chen qemu-devel qemu-trivial 3 versions – Applied

Status from this message: Applied to trivial-patches, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 7 repliesApplied
  2. v23 patches 25 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- dropped [PATCH 1/3]. Took the simpler approach not to re-order cpu_exec_realizefn() call.
- changed patch title in [PATCH V3 1/2]
- don't set CPUID_EXT_MONITOR in kvm_cpu_realizefn()

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2vl: Allow multiple -overcommit commandssystem/vl.c+2 -21 reply
2/2target/i386: Advertise MWAIT iff host supportstarget/i386/host-cpu.c target/i386/kvm/kvm-cpu.c+9 -143 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchThomas HuthZhao LiuXiaoyao LiIgor Mammedov
1/2R-b R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH V3 0/2] improve -overcommit cpu-pm=on|off

Currently, if running "-overcommit cpu-pm=on" on hosts that don't have MWAIT support, the MWAIT/MONITOR feature is advertised to the guest and executing MWAIT/MONITOR on the guest triggers #UD.

Typically #UD takes priority over VM-Exit interception checks and KVM doesn't emulate MONITOR/MWAIT. This causes the guest fail to boot.

V2:
- [PATCH 1]: took Thomas' suggestion for more generic fix
- [PATCH 2/3]: no changes

V3:
- dropped [PATCH 1/3]. Took the simpler approach not to re-order cpu_exec_realizefn() call.
- changed patch title in [PATCH V3 1/2]
- don't set CPUID_EXT_MONITOR in kvm_cpu_realizefn()

Zide Chen (2):
vl: Allow multiple -overcommit commands
target/i386: Advertise MWAIT iff host supports

 system/vl.c               |  4 ++--
 target/i386/host-cpu.c    | 12 ------------
 target/i386/kvm/kvm-cpu.c | 11 +++++++++--
 3 files changed, 11 insertions(+), 16 deletions(-)
Signature · 1 line
2.34.1