Skip to content

RFC drm/vkms: Completly split headers

Louis Chauvet dri-devel lkml 1 version In review

Get series with b4
b4 am [email protected] change-id 20240521-google-split-headers-4a3705228f32

Versions newest first

  1. v1 RFC Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/vkms: Properly extract vkms_formats headerdrivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_formats.c drivers/gpu/drm/vkms/vkms_formats.h+84 -732 replies
2/6drm/vkms: Extract vkms_writeback headerdrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_formats.c +3 more+26 -111 reply
3/6drm/vkms: Extract vkms_plane headerdrivers/gpu/drm/vkms/vkms_crtc.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_formats.c +5 more+74 -591 reply
4/6drm/vkms: Rename to_vkms_plane_state to avoid confusiondrivers/gpu/drm/vkms/vkms_crtc.c drivers/gpu/drm/vkms/vkms_plane.c drivers/gpu/drm/vkms/vkms_plane.h+4 -41 reply
5/6drm/vkms: Extract vkms_crtc headerdrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_crtc.c drivers/gpu/drm/vkms/vkms_crtc.h +5 more+92 -481 reply
6/6drm/vkms: Extract vkms_composer headerdrivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_composer.h drivers/gpu/drm/vkms/vkms_crtc.c +2 more+22 -111 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJosé Expósito
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 0/6] drm/vkms: Completly split headers

VKMS code is already splitted in many files. In order to avoid mixing code, this series aims to properly add a header for each .c.

It will help for the readability as each function defined in a .c will be declared in its own .h, and not mixed with other in a big vkms_drv.h. This will help a lot for the managment of multiple devices and the introduction of ConfigFS.

This series depends on [1].

[1]: https://lore.kernel.org/all/[email protected]/

---
Louis Chauvet (6):
drm/vkms: Properly extract vkms_formats header drm/vkms: Extract vkms_writeback header drm/vkms: Extract vkms_plane header
drm/vkms: Rename to_vkms_plane_state to avoid confusion drm/vkms: Extract vkms_crtc header
drm/vkms: Extract vkms_composer header

 drivers/gpu/drm/vkms/vkms_composer.c  |   5 +-
 drivers/gpu/drm/vkms/vkms_composer.h  |  18 ++++
 drivers/gpu/drm/vkms/vkms_crtc.c      |   7 +-
 drivers/gpu/drm/vkms/vkms_crtc.h      |  87 +++++++++++++++
 drivers/gpu/drm/vkms/vkms_drv.c       |   1 +
 drivers/gpu/drm/vkms/vkms_drv.h       | 192 ----------------------------------
 drivers/gpu/drm/vkms/vkms_formats.c   |   4 +
 drivers/gpu/drm/vkms/vkms_formats.h   |  80 +++++++++++++-
 drivers/gpu/drm/vkms/vkms_output.c    |   5 +-
 drivers/gpu/drm/vkms/vkms_plane.c     |   7 +-
 drivers/gpu/drm/vkms/vkms_plane.h     |  64 ++++++++++++
 drivers/gpu/drm/vkms/vkms_writeback.c |   5 +-
 drivers/gpu/drm/vkms/vkms_writeback.h |  21 ++++
 13 files changed, 296 insertions(+), 200 deletions(-)

---
base-commit: 219b45d023ed0902b05c5902a4f31c2c38bcf68c
change-id: 20240521-google-split-headers-4a3705228f32
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: ae2d8b2efbbaa9decce56632c498c87e708288b3
prerequisite-patch-id: c26b6d4867eaf6566195aa0002765357d4f69f8c
prerequisite-patch-id: 8791d34a6f3148dc518da5249453067e40d346e3
prerequisite-patch-id: 26ec7cd5a449004bcfd6ce483671f87655f8635c
prerequisite-patch-id: 2e855ba871f2e99d4b6b7d85da2ddac6bb32262e
prerequisite-patch-id: 82523a917646793deeec7cdcc7ff286bd924fd21
prerequisite-patch-id: 0e355e5316281f53ab5e97ab6e63b0a682f3eb9e
prerequisite-patch-id: 7a63d245a377d5f5283f48e8f52421b912811752
prerequisite-patch-id: dda6bf4692cd1795c489ff58e72c0841ea8ffbc4
prerequisite-patch-id: f70e535b6086cc587975fbfa75741f485f679a32
prerequisite-patch-id: 6c2aa2645c7d854951608aa4d15a02e076abe1fe
prerequisite-patch-id: dc61c6d3db73053fc36e115af561e0c42b467de2
prerequisite-patch-id: deda292af6d8bbf6762b0bf4d351ffd2225995d8
prerequisite-patch-id: 18554f49b53cbcfd4a8ca50dc83b17dd3cf96474
prerequisite-patch-id: 5633292e10132d29be2467812e6e2e824cfedb67
prerequisite-patch-id: 43f37e9c1bc041d491e41dfb59548ed258a1e071
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: d10db4cb12a88de2e5f6440e9fcf5ddda191e3cd
prerequisite-patch-id: 16bac0ef1f1dc010a72ce2faae66631797d23d3f
prerequisite-patch-id: 8e0e5cc0727e8fd2d14ebafc5538fd987c2dd38e
prerequisite-patch-id: 32bad3bf3df46d042e9edd4c1259c2e2a3fb8975
prerequisite-patch-id: 4bd9e4cef308abd17b7b274a5575a3de73a1503b
prerequisite-patch-id: a98fac5a2c60fe23fbc6a455e9a4ab8b0f187ee8
prerequisite-patch-id: 62c8d109a22b9978f755255b67f13fe74fb7008d
prerequisite-patch-id: baa8da4871dd90b03a07c6d9ddb45e10929ee70a
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: df699289213021fa202fcdf1b4bdff513d09caa2
prerequisite-patch-id: 59d021ccb166fbe2962de9cda72aceb3caa9cabe
prerequisite-patch-id: 895ace6d58b3776798791705b7b05e26b8d37c7b
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: a4408d1de7730262456bdd618d3cb86f5f5b01ba
prerequisite-patch-id: f215b5aee5644d2e5b1b2af0bb0f4f1e7609558b
prerequisite-patch-id: d4f3b4c714324c5f326af3daba394899e6663d75

Best regards,

Signature · 1 line
Louis Chauvet <[email protected]>