Skip to content

'eeprom' command improvements

Marek Behún u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11common: eeprom_layout: Assign default layout methods and parameters before specific onescommon/eeprom/eeprom_layout.c+4 -40 replies
2/11common: eeprom_layout: Split field finding code from the field update functioncommon/eeprom/eeprom_layout.c include/eeprom_layout.h+35 -150 replies
3/11common: eeprom_field: Fix updating binary fieldcommon/eeprom/eeprom_field.c+1 -10 replies
4/11common: eeprom_field: Drop unnecessary comparisoncommon/eeprom/eeprom_field.c+1 -10 replies
5/11cmd: eeprom: Fix usage help for the eeprom commandcmd/eeprom.c+4 -40 replies
6/11cmd: eeprom: Hide eeprom layout versioning behind a Kconfig optioncmd/Kconfig cmd/eeprom.c configs/cm_fx6_defconfig +1 more+25 -60 replies
7/11cmd: eeprom: Deduplicate parse_i2c_bus_addr() callscmd/eeprom.c+17 -190 replies
8/11cmd: eeprom: Refactor eeprom device specifier parsingcmd/eeprom.c+41 -360 replies
9/11cmd: eeprom: Refactor command execution into function by actioncmd/eeprom.c+71 -400 replies
10/11cmd: eeprom: Don't read/write whole EEPROM if not necessarycmd/eeprom.c+2 -90 replies
11/11cmd: eeprom: Extend to EEPROMs probed via driver modelcmd/eeprom.c+112 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] 'eeprom' command improvements

Hi Tom,

this series contains improvements for the 'eeprom' command:
- refactors
- fixes
- improvements
- ability to use driver model EEPROMs (uclass UCLASS_I2C_EEPROM)
- more flexible EEPROM layout support

It should not cause any behavior change for any existing board.

This series is a dependency for some DDR issue fixes for Turris Omnia. I will be sending that one separately.

github PR link (with CI):
https://github.com/u-boot/u-boot/pull/540
- there is a failure for
test.py for sandbox sandbox_clang
but it seems unrelated to these changes

Marek Behún (11):
common: eeprom_layout: Assign default layout methods and parameters
before specific ones
common: eeprom_layout: Split field finding code from the field update
function
common: eeprom_field: Fix updating binary field
common: eeprom_field: Drop unnecessary comparison
cmd: eeprom: Fix usage help for the eeprom command
cmd: eeprom: Hide eeprom layout versioning behind a Kconfig option
cmd: eeprom: Deduplicate parse_i2c_bus_addr() calls
cmd: eeprom: Refactor eeprom device specifier parsing
cmd: eeprom: Refactor command execution into function by action
cmd: eeprom: Don't read/write whole EEPROM if not necessary
cmd: eeprom: Extend to EEPROMs probed via driver model

 cmd/Kconfig                   |   9 +-
 cmd/eeprom.c                  | 305 +++++++++++++++++++++++++---------
 common/eeprom/eeprom_field.c  |   4 +-
 common/eeprom/eeprom_layout.c |  54 +++---
 configs/cm_fx6_defconfig      |   1 +
 configs/cm_t43_defconfig      |   1 +
 include/eeprom_layout.h       |   4 +
 7 files changed, 273 insertions(+), 105 deletions(-)
Signature · 1 line
2.44.1