Skip to content

RFC mm: page_type, zsmalloc and page_mapcount_reset()

David Hildenbrand linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mm: update _mapcount and page_type documentationinclude/linux/mm.h include/linux/mm_types.h+15 -141 reply
2/6mm: allow reuse of the lower 16bit of the page type with an actual typeinclude/linux/mm_types.h include/linux/page-flags.h+19 -81 reply
3/6mm/zsmalloc: use a proper page typeinclude/linux/page-flags.h mm/Kconfig mm/zsmalloc.c+23 -43 replies
4/6mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pagesmm/page_alloc.c+4 -20 replies
5/6mm/filemap: reinitialize folio->_mapcount directlymm/filemap.c+1 -10 replies
6/6mm/mm_init: initialize page->_mapcount directly in__init_single_page()include/linux/mm.h include/linux/mm_types.h mm/mm_init.c+2 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/6] mm: page_type, zsmalloc and page_mapcount_reset()

Wanting to remove the remaining abuser of _mapcount/page_type along with page_mapcount_reset(), I stumbled over zsmalloc, which is yet to be converted away from "struct page" [1].

Unfortunately, we cannot stop using the page_type field in zsmalloc code completely for its own purposes. All other fields in "struct page" are used one way or the other.

... but we can limit the abuse to 16 bit, glue it to a apge type that must be set, and document it. page_has_type() will always successfully indicate such zsmalloc pages, and such zsmalloc pages only.

We lose zsmalloc support for PAGE_SIZE > 64KB, which should be tolerable. We could use more bits from the page type, but 16 bit sounds like a good idea.

So clarify the _mapcount/page_type documentation, use a proper page_type for zsmalloc, and remove page_mapcount_reset().

Only lightly tested with zram. Will have to do more testing and cross-compile checking.

[1] https://lore.kernel.org/all/[email protected]/

Cc Andrew Morton <[email protected]>
Cc "Matthew Wilcox (Oracle)" <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Minchan Kim <[email protected]>
Cc Sergey Senozhatsky <[email protected]>
Cc Hyeonggon Yoo <[email protected]>

David Hildenbrand (6):
mm: update _mapcount and page_type documentation
mm: allow reuse of the lower 16bit of the page type with an actual
type
mm/zsmalloc: use a proper page type
mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages mm/filemap: reinitialize folio->_mapcount directly mm/mm_init: initialize page->_mapcount directly in__init_single_page()

 include/linux/mm.h         | 10 ----------
 include/linux/mm_types.h   | 29 ++++++++++++++++++++---------
 include/linux/page-flags.h | 25 +++++++++++++++++--------
 mm/Kconfig                 |  1 +
 mm/filemap.c               |  2 +-
 mm/mm_init.c               |  2 +-
 mm/page_alloc.c            |  6 ++++--
 mm/zsmalloc.c              | 23 +++++++++++++++++++----
 8 files changed, 63 insertions(+), 35 deletions(-)

base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63

Signature · 1 line
2.45.0