Skip to content

Extend 8-byte PCI load/store support to x86 arch

Ramesh Thomas kvm linux-s390 3 versions – Applied

Status from this message: Applied to vfio next branch for v6.14. Thanks,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied
  2. v22 patches 3 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2vfio/pci: Enable iowrite64 and ioread64 for vfio pcidrivers/vfio/pci/vfio_pci_rdwr.c+1 -01 reply
2/2vfio/pci: Remove #ifdef iowrite64 and #ifdef ioread64drivers/vfio/pci/vfio_pci_rdwr.c+0 -121 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJason Gunthorpe
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Extend 8-byte PCI load/store support to x86 arch

This patch series extends the recently added 8-byte PCI load/store support to the x86 architecture.

Refer patch series adding above support:
https://lore.kernel.org/all/[email protected]/

The 8-byte implementations are enclosed inside #ifdef checks of the macros "ioread64" and "iowrite64". These macros don't get defined if CONFIG_GENERIC_IOMAP is defined. CONFIG_GENERIC_IOMAP gets defined for x86 and hence the macros are undefined. Due to this the 8-byte support was not enabled for x86 architecture.

To resolve this, include the header file io-64-nonatomic-lo-hi.h that maps the ioread64 and iowrite64 macros to a generic implementation in lib/iomap.c. This was the intention of defining CONFIG_GENERIC_IOMAP.

Tested using a pass-through PCI device bound to vfio-pci driver and doing BAR reads and writes that trigger calls to vfio_pci_core_do_io_rw() that does the 8-byte reads and writes.

Patch history:
v3: Do not add the check for CONFIG_64BIT and only remove the checks for ioread64 and iowrite64.

v2: Based on Jason's feedback moved #include io-64-nonatomic-lo-hi.h to vfio_pci_rdwr.c and replaced #ifdef checks of iowrite64 and ioread64 macros with checks for CONFIG_64BIT.

https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

Ramesh Thomas (2):
vfio/pci: Enable iowrite64 and ioread64 for vfio pci vfio/pci: Remove #ifdef iowrite64 and #ifdef ioread64

 drivers/vfio/pci/vfio_pci_rdwr.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
Signature · 1 line
2.34.1