Skip to content

tools: tests: fix a few issues in bash scripts

Bartosz Golaszewski linux-gpio 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20240524-fix-bash-tests-545bf26447b3

Versions newest first

  1. v3 Latest4 patches 3 repliesApplied
  2. v24 patches 18 repliesSuperseded
  3. v14 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Use $* in the message string in assert_fail()
- Make shellcheck happy when using find exclusively instead of find + grep
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4tools: tests: use tabs for indentation consistentlytools/gpio-tools-test.bash+7 -70 replies
2/4tools: tests: use "$@" instead of $*tools/gpio-tools-test.bash+5 -50 replies
3/4tools: tests: remove unneeded ';' in while loopstools/gpio-tools-test.bash+2 -20 replies
4/4tools: tests: remove dependency on greptools/gpio-tools-test.bash+4 -140 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKent GibsonAndy Shevchenko
SeriesR-b R-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH libgpiod v3 0/4] tools: tests: fix a few issues in bash scripts

Fix a few issues with tools tests reported by Andy.

---
Changes in v3:
- Use $* in the message string in assert_fail()
- Make shellcheck happy when using find exclusively instead of find + grep
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Use double quotes around $@ to prevent globbing but allow variable expansion
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Bartosz Golaszewski (4):
tools: tests: use tabs for indentation consistently
tools: tests: use "$@" instead of $*
tools: tests: remove unneeded ';' in while loops
tools: tests: remove dependency on grep

 tools/gpio-tools-test.bash | 46 ++++++++++++++++++----------------------------
 1 file changed, 18 insertions(+), 28 deletions(-)

---
base-commit: 27fe10150f6d5fa78d1a1ef1e922dc8395d1154d
change-id: 20240524-fix-bash-tests-545bf26447b3

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>