Skip to content

use new mount API for bcachefs

Thomas Bertschinger linux-bcachefs linux-fsdevel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bcachefs: add printbuf arg to bch2_parse_mount_opts()fs/bcachefs/chardev.c fs/bcachefs/fs.c fs/bcachefs/opts.c +1 more+71 -490 replies
2/3bcachefs: Add error code to defer option parsingfs/bcachefs/disk_groups.c fs/bcachefs/errcode.h fs/bcachefs/opts.c+18 -20 replies
3/3bcachefs: use new mount APIfs/bcachefs/fs.c fs/bcachefs/opts.h+99 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] use new mount API for bcachefs

This updates bcachefs to use the new fs_context_operations functions for mounting and remounting.

However, rather than using the parsing utilities defined in fs_parser.h, I stick with using the existing options parsing code that bcachefs already has. This simplifies the changes, since integrating the bcachefs options with the generic parsing utilities in fs_context would otherwise involve some tricky macro manipulations.

Following this series is a new test in Ktest [1] which exercises mount and remount functionality to test the new code.

[1] https://evilpiepirate.org/git/ktest.git/

Thomas Bertschinger (3):
bcachefs: add printbuf arg to bch2_parse_mount_opts()
bcachefs: Add error code to defer option parsing
bcachefs: use new mount API

 fs/bcachefs/chardev.c     |   4 +-
 fs/bcachefs/disk_groups.c |   2 +-
 fs/bcachefs/errcode.h     |   3 +-
 fs/bcachefs/fs.c          | 113 ++++++++++++++++++++++++++++-------
 fs/bcachefs/opts.c        | 120 ++++++++++++++++++++++++--------------
 fs/bcachefs/opts.h        |  12 +++-
 6 files changed, 185 insertions(+), 69 deletions(-)
Signature · 1 line
2.45.0