Skip to content

net/mlx5e: SHAMPO, Enable HW GRO once more

Tariq Toukan netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 2 repliesApplied 14/14
  2. v115 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Dropped the patch that adds no-split counters, we plan to add in the future with detailed documentation.

Patches in v2 All 14 applied

#Subject and filesSizeRepliesApplied
1/14net/mlx5e: SHAMPO, Use net_prefetch APIdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+3 -30 repliesApplied
2/14net/mlx5e: SHAMPO, Fix incorrect page releasedrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+2 -12 repliesApplied
3/14net/mlx5e: SHAMPO, Fix invalid WQ linked list unlinkdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+3 -00 repliesApplied
4/14net/mlx5e: SHAMPO, Fix FCS config when HW GRO ondrivers/net/ethernet/mellanox/mlx5/core/en_main.c+9 -30 repliesApplied
5/14net/mlx5e: SHAMPO, Disable gso_size for non GRO packetsdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+2 -00 repliesApplied
6/14net/mlx5e: SHAMPO, Simplify header page release in teardowndrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/ethernet/mellanox/mlx5/core/en_rx.c+17 -580 repliesApplied
7/14net/mlx5e: SHAMPO, Specialize mlx5e_fill_skb_data()drivers/net/ethernet/mellanox/mlx5/core/en_rx.c+11 -140 repliesApplied
8/14net/mlx5e: SHAMPO, Skipping on duplicate flush of the same SHAMPO SKBdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+1 -10 repliesApplied
9/14net/mlx5e: SHAMPO, Make GRO counters more preciseDocumentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst drivers/net/ethernet/mellanox/mlx5/core/en_rx.c+14 -90 repliesApplied
10/14net/mlx5e: SHAMPO, Drop rx_gro_match_packets counterDocumentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst drivers/net/ethernet/mellanox/mlx5/core/en_rx.c drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +1 more+0 -120 repliesApplied
11/14net/mlx5e: SHAMPO, Add header-only ethtool counters for header data splitDocumentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst drivers/net/ethernet/mellanox/mlx5/core/en_rx.c drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +1 more+20 -00 repliesApplied
12/14net/mlx5e: SHAMPO, Use KSMs instead of KLMsdrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/params.c drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h +3 more+71 -670 repliesApplied
13/14net/mlx5e: SHAMPO, Re-enable HW-GROdrivers/net/ethernet/mellanox/mlx5/core/en_main.c include/linux/mlx5/mlx5_ifc.h+37 -50 repliesApplied
14/14net/mlx5e: SHAMPO, Coalesce skb fragments to page sizedrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+13 -60 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next V2 00/14] net/mlx5e: SHAMPO, Enable HW GRO once more

This series enables hardware GRO for ConnectX-7 and newer NICs. SHAMPO stands for Split Header And Merge Payload Offload.

The first part of the series contains important fixes and improvements.

The second part reworks the HW GRO counters.

Lastly, HW GRO is perf optimized and enabled.

Here are the bandwidth numbers for a simple iperf3 test over a single rq where the application and irq are pinned to the same CPU:

+---------+--------+--------+-----------+-------------+
| streams | SW GRO | HW GRO | Unit      | Improvement |
+---------+--------+--------+-----------+-------------+
| 1       | 36     | 57     | Gbits/sec |    1.6 x    |
| 4       | 34     | 50     | Gbits/sec |    1.5 x    |
| 8       | 31     | 43     | Gbits/sec |    1.4 x    |
+---------+--------+--------+-----------+-------------+

Benchmark details:
VM based setup
CPU: Intel(R) Xeon(R) Platinum 8380 CPU, 24 cores
NIC: ConnectX-7 100GbE
iperf3 and irq running on same CPU over a single receive queue

Series generated against:
commit 83042ce9b7c3 ("Merge branch 'Felix-DSA-probing-cleanup'")

Thanks,
Tariq.

V2:
- Dropped the patch that adds no-split counters, we plan to add in the future with detailed documentation.

Dragos Tatulea (9):
net/mlx5e: SHAMPO, Fix incorrect page release net/mlx5e: SHAMPO, Fix invalid WQ linked list unlink net/mlx5e: SHAMPO, Fix FCS config when HW GRO on net/mlx5e: SHAMPO, Disable gso_size for non GRO packets net/mlx5e: SHAMPO, Simplify header page release in teardown net/mlx5e: SHAMPO, Specialize mlx5e_fill_skb_data() net/mlx5e: SHAMPO, Make GRO counters more precise net/mlx5e: SHAMPO, Drop rx_gro_match_packets counter net/mlx5e: SHAMPO, Coalesce skb fragments to page size

Tariq Toukan (2):
net/mlx5e: SHAMPO, Use net_prefetch API
net/mlx5e: SHAMPO, Add header-only ethtool counters for header data
split

Yoray Zack (3):
net/mlx5e: SHAMPO, Skipping on duplicate flush of the same SHAMPO SKB net/mlx5e: SHAMPO, Use KSMs instead of KLMs
net/mlx5e: SHAMPO, Re-enable HW-GRO

 .../ethernet/mellanox/mlx5/counters.rst       |  24 ++-
 drivers/net/ethernet/mellanox/mlx5/core/en.h  |  22 +-
 .../ethernet/mellanox/mlx5/core/en/params.c   |  12 +-
 .../net/ethernet/mellanox/mlx5/core/en/txrx.h |  19 ++
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  71 ++++--
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 202 ++++++++----------
 .../ethernet/mellanox/mlx5/core/en_stats.c    |   7 +-
 .../ethernet/mellanox/mlx5/core/en_stats.h    |   6 +-
 include/linux/mlx5/device.h                   |   1 +
 include/linux/mlx5/mlx5_ifc.h                 |  16 +-
 10 files changed, 202 insertions(+), 178 deletions(-)
Signature · 1 line
2.44.0