Skip to content

Add support for NMI-source reporting

Jacob Pan linux-perf-users lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 5 repliesIn review
  2. v311 patches 21 repliesSuperseded
  3. v26 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches9 repliesSuperseded

Changes in v4 from the cover letter

- Mostly coding style, comments, and naming changes (Li Xin, Nikolay, Kan)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11x86/irq: Add enumeration of NMI source reporting CPU featurearch/x86/include/asm/cpufeatures.h arch/x86/kernel/traps.c+4 -10 replies
2/11x86/irq: Define NMI source vectorsarch/x86/include/asm/irq_vectors.h+30 -00 replies
3/11x86/irq: Extend NMI handler registration interface to include sourcearch/x86/events/amd/ibs.c arch/x86/events/core.c arch/x86/include/asm/nmi.h +13 more+46 -200 replies
4/11x86/irq: Factor out common NMI handling codearch/x86/kernel/nmi.c+16 -120 replies
5/11x86/irq: Process nmi sources in NMI handlerarch/x86/kernel/nmi.c+82 -10 replies
6/11KVM: VMX: Expand FRED kvm entry with event dataarch/x86/entry/entry_64_fred.S arch/x86/include/asm/fred.h arch/x86/kvm/vmx/vmx.c+7 -71 reply
7/11KVM: VMX: Handle NMI Source report in VM exitarch/x86/kvm/vmx/vmx.c+8 -31 reply
8/11perf/x86: Enable NMI source reporting for perfmonarch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/include/asm/apic.h+7 -51 reply
9/11x86/irq: Enable NMI source on IPIs delivered as NMIarch/x86/include/asm/irq_vectors.h arch/x86/kernel/apic/hw_nmi.c arch/x86/kernel/apic/ipi.c +6 more+31 -141 reply
10/11x86/irq: Move __prepare_ICR to x86 common headerarch/x86/include/asm/apic.h arch/x86/kernel/apic/local.h+21 -220 replies
11/11KVM: X86: Use common code for PV IPIs in linux guestarch/x86/kernel/kvm.c+1 -91 reply

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchZeng GuangKan Liang
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11R-b
9/11
10/11
11/11Originally-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/11] Add support for NMI-source reporting

Hi Thomas and all,

Non-Maskable Interrupts (NMIs) are routed to the local Advanced Programmable Interrupt Controller (APIC) using vector #2. Before the advent of the Flexible Return and Event Delivery (FRED)[1], the vector information set by the NMI initiator was disregarded or lost within the hardware, compelling system software to poll every registered NMI handler to pinpoint the source of the NMI[2]. This approach led to several issues:

1. Inefficiency due to the CPU's time spent polling all handlers.
2. Increased latency from the additional time taken to poll all handlers.
3. The occurrence of unnecessary NMIs if they are triggered shortly
after being processed by a different source.

To tackle these challenges, Intel introduced NMI source reporting as a part of the FRED specification (detailed in Chapter 9). This CPU feature ensures that while all NMI sources are still aggregated into NMI vector (#2) for delivery, the source of the NMI is now conveyed through FRED event data (a 16-bit bitmap on the stack). This allows for the selective dispatch of the NMI source handler based on the bitmap, eliminating the need to invoke all NMI source handlers indiscriminately.

In line with the hardware architecture, various interrupt sources can generate NMIs by encoding an NMI delivery mode. However, this patchset activates only the local NMI sources that are currently utilized by the Linux kernel, which includes:

1. Performance monitoring.
2. Inter-Processor Interrupts (IPIs) for functions like CPU backtrace,
machine check, Kernel GNU Debugger (KGDB), reboot, panic stop, and self-test.

Other NMI sources will continue to be handled as previously when the NMI source is not utilized or remains unidentified.

Next steps:
1. KVM support
2. Optimization to reuse IDT NMI vector 2 as NMI source for "known" source.

[1] https://www.intel.com/content/www/us/en/content-details/779982/flexible-return-and-event-delivery-fred-specification.html
[2] https://lore.kernel.org/lkml/171011362209.2468526.15187874627966416701.tglx@xen13/

Thanks,

Jacob

---
V4:
- Mostly coding style, comments, and naming changes (Li Xin, Nikolay, Kan)
V3:
- Added KVM VMX patches to handle NMI exits (Sean)
- Clean up in KVM for code reuse in PV IPI (patch 10 and 11)
- Misc fixes based on reviews from HPA, Li Xin, and Sohil

Change logs are in individual patches.

Thanks,

Jacob

Jacob Pan (9):
x86/irq: Add enumeration of NMI source reporting CPU feature x86/irq: Define NMI source vectors
x86/irq: Extend NMI handler registration interface to include source x86/irq: Factor out common NMI handling code
x86/irq: Process nmi sources in NMI handler
perf/x86: Enable NMI source reporting for perfmon x86/irq: Enable NMI source on IPIs delivered as NMI x86/irq: Move __prepare_ICR to x86 common header
KVM: X86: Use common code for PV IPIs in linux guest

Zeng Guang (2):
KVM: VMX: Expand FRED kvm entry with event data
KVM: VMX: Handle NMI Source report in VM exit

 arch/x86/entry/entry_64_fred.S     |   2 +-
 arch/x86/events/amd/ibs.c          |   2 +-
 arch/x86/events/core.c             |   7 +-
 arch/x86/events/intel/core.c       |   6 +-
 arch/x86/include/asm/apic.h        |  23 ++++++
 arch/x86/include/asm/cpufeatures.h |   1 +
 arch/x86/include/asm/fred.h        |   8 +-
 arch/x86/include/asm/irq_vectors.h |  40 +++++++++
 arch/x86/include/asm/nmi.h         |   4 +-
 arch/x86/kernel/apic/hw_nmi.c      |   5 +-
 arch/x86/kernel/apic/ipi.c         |   4 +-
 arch/x86/kernel/apic/local.h       |  16 ----
 arch/x86/kernel/cpu/mce/inject.c   |   4 +-
 arch/x86/kernel/cpu/mshyperv.c     |   2 +-
 arch/x86/kernel/kgdb.c             |   6 +-
 arch/x86/kernel/kvm.c              |  10 +--
 arch/x86/kernel/nmi.c              | 127 ++++++++++++++++++++++++++---
 arch/x86/kernel/nmi_selftest.c     |   7 +-
 arch/x86/kernel/reboot.c           |   4 +-
 arch/x86/kernel/smp.c              |   4 +-
 arch/x86/kernel/traps.c            |   4 +-
 arch/x86/kvm/vmx/vmx.c             |  13 ++-
 arch/x86/platform/uv/uv_nmi.c      |   4 +-
 drivers/acpi/apei/ghes.c           |   2 +-
 drivers/char/ipmi/ipmi_watchdog.c  |   2 +-
 drivers/edac/igen6_edac.c          |   2 +-
 drivers/watchdog/hpwdt.c           |   6 +-
 27 files changed, 237 insertions(+), 78 deletions(-)
Signature · 1 line
2.25.1