Skip to content

Tracing cleanup and add mmio tracing

Radhakrishna Sripada intel-xe 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyIn review
  2. v56 patches 4 repliesSuperseded
  3. v46 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v36 patches9 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/xe/trace: Extract bo, vm, vma tracesdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_gt_pagefault.c +5 more+250 -2160 replies
2/6drm/xe/trace: Extract guc related tracesdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_guc_ct.c drivers/gpu/drm/xe/xe_trace.h +2 more+114 -810 replies
3/6drm/xe/trace: Print device_id in xe_trace_bo eventsdrivers/gpu/drm/xe/xe_trace_bo.h+20 -90 replies
4/6drm/xe/trace: Print device_id in xe_trace_guc eventsdrivers/gpu/drm/xe/xe_guc_ct.c drivers/gpu/drm/xe/xe_trace_guc.h+33 -250 replies
5/6drm/xe/trace: Print device_id in xe_trace eventsdrivers/gpu/drm/xe/xe_gt_tlb_invalidation.c drivers/gpu/drm/xe/xe_pt.c drivers/gpu/drm/xe/xe_trace.h+59 -400 replies
6/6drm/xe: Add reg read/write tracedrivers/gpu/drm/xe/xe_mmio.c drivers/gpu/drm/xe/xe_trace.h+47 -41 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchGustavo Sousa
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6Reviewd-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/6] Tracing cleanup and add mmio tracing

xe_trace.h is getting bloated. Group related events to their own files. All bo, vm and vma related events have been moved to xe_trace_bo.h. GuC related trace events have been moved to xe_trace_guc.h. Patches 1 and 2 splits the trace events into seperate files.

In multi gpu environments, it is important to know the device from which the event was triggered. Print the device id information along with the trace information being printed. Patches 3, 4 and 5 make changes to print the device id's if not already captured.

Mmio reg read writes are important tracing information that needs to be captured and will be helpful in display debug. Patch 6 adds the reg read/write tracing support.

Earlier versions of patch 6 can be found here:
v1: https://patchwork.freedesktop.org/series/119312/
v2: https://patchwork.freedesktop.org/series/132626/

v4: Fixes the review comments from Gustavo
v5: Fixes the kunit error reported.
v6: Remove unused string_helper inclusion in trace files and other
minor cleanups

Radhakrishna Sripada (6):
drm/xe/trace: Extract bo, vm, vma traces drm/xe/trace: Extract guc related traces drm/xe/trace: Print device_id in xe_trace_bo events drm/xe/trace: Print device_id in xe_trace_guc events drm/xe/trace: Print device_id in xe_trace events drm/xe: Add reg read/write trace

 drivers/gpu/drm/xe/Makefile                 |   2 +
 drivers/gpu/drm/xe/xe_bo.c                  |   2 +-
 drivers/gpu/drm/xe/xe_gt_pagefault.c        |   2 +-
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c |  27 +-
 drivers/gpu/drm/xe/xe_guc_ct.c              |  13 +-
 drivers/gpu/drm/xe/xe_migrate.c             |   2 +-
 drivers/gpu/drm/xe/xe_mmio.c                |  23 +-
 drivers/gpu/drm/xe/xe_pt.c                  |   8 +-
 drivers/gpu/drm/xe/xe_trace.h               | 380 ++++----------------
 drivers/gpu/drm/xe/xe_trace_bo.c            |   9 +
 drivers/gpu/drm/xe/xe_trace_bo.h            | 247 +++++++++++++
 drivers/gpu/drm/xe/xe_trace_guc.c           |   9 +
 drivers/gpu/drm/xe/xe_trace_guc.h           | 110 ++++++
 drivers/gpu/drm/xe/xe_vm.c                  |   2 +-
 14 files changed, 492 insertions(+), 344 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.c
 create mode 100644 drivers/gpu/drm/xe/xe_trace_bo.h
 create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.c
 create mode 100644 drivers/gpu/drm/xe/xe_trace_guc.h
Signature · 1 line
2.34.1