Skip to content

net: tcp: un-pin tw timer

Florian Westphal netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest3 patches 2 repliesApplied 3/3
  2. v73 patches 8 repliesSuperseded
  3. v63 patches 7 repliesSuperseded

Patches in v8 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: tcp/dccp: prepare for tw_timer un-pinninginclude/net/inet_timewait_sock.h net/dccp/minisocks.c net/ipv4/inet_timewait_sock.c +2 more+52 -140 repliesApplied
2/3net: tcp: un-pin the tw_timernet/dccp/minisocks.c net/ipv4/inet_timewait_sock.c net/ipv4/tcp_minisocks.c+4 -141 replyApplied
3/3tcp: move inet_twsk_schedule helper out of headerinclude/net/inet_timewait_sock.h net/ipv4/inet_timewait_sock.c+5 -50 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric DumazetSebastian Andrzej Siewior
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH net-next v8 0/3] net: tcp: un-pin tw timer

Changes since previous iteration:
- Patch 1: update a comment, I copied Erics v7 RvB tag.
- Patch 2: move bh off/on into hashdance_schedule and get rid of comment mentioning pinned tw timer.
I did not copy Erics RvB tag over from v7 because of the change.
- Patch 3 is unchanged, so I kept Erics RvB tag.

This is v8 of the series where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups.

First patch makes necessary preparations, existing code relies on TIMER_PINNED to avoid races.

Second patch un-pins the TW timer. Could be folded into the first one, but it might help wrt. bisection.

Third patch is a minor cleanup to move a helper from .h to the only remaining compilation unit.

Tested with iperf3 and stress-ng socket mode.

Florian Westphal (2):
net: tcp: un-pin the tw_timer
tcp: move inet_twsk_schedule helper out of header

Valentin Schneider (1):
net: tcp/dccp: prepare for tw_timer un-pinning

 include/net/inet_timewait_sock.h | 11 ++----
 net/dccp/minisocks.c             |  9 +----
 net/ipv4/inet_timewait_sock.c    | 63 +++++++++++++++++++++++++++-----
 net/ipv4/tcp_ipv4.c              |  2 +-
 net/ipv4/tcp_minisocks.c         |  9 +----
 5 files changed, 61 insertions(+), 33 deletions(-)
Signature · 1 line
2.44.2