Skip to content

soundwire: bus: suppress probe deferral errors

Johan Hovold alsa-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v24 patches 12 repliesSuperseded
  3. v11 patch 1 replySuperseded

Changes in v3 from the cover letter

- amend the update status error message with "at probe" to make it more descriptive (it's already unique)
- drop the patch dropping a probe debug message

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3soundwire: bus: suppress probe deferral errorsdrivers/soundwire/bus_type.c+0 -61 reply
2/3soundwire: bus: drop unused driver name fielddrivers/soundwire/bus_type.c include/linux/soundwire/sdw.h+2 -91 reply
3/3soundwire: bus: clean up probe warningsdrivers/soundwire/bus_type.c+2 -20 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis Bossart
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] soundwire: bus: suppress probe deferral errors

The soundwire bus code is incorrectly logging probe deferrals as errors.

This series addresses that, cleans up the soundwire bus logging and drops the unused soudwire driver name field.

Vinod, I booted linux-next yesterday and realised that these bogus error messages are still spamming the logs when booting x1e80100 and making it harder to see the valid warnings (which there were too many of). Would be nice to have this fixed in 6.11:

[   18.815950] wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517
[   18.825093] wsa884x-codec sdw:1:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517
[   18.832335] wsa884x-codec sdw:4:0:0217:0204:00:1: Probe of wsa884x-codec failed: -517
[   18.840870] wsa884x-codec sdw:1:0:0217:0204:00:1: Probe of wsa884x-codec failed: -517
[   18.848463] wsa884x-codec sdw:1:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517

Johan

Changes in v3
- amend the update status error message with "at probe" to make it more descriptive (it's already unique)
- drop the patch dropping a probe debug message

Changes in v2
- drop probe error message completely
- drop soundwire driver name field
- cleanup probe warning messages
- drop probe debug message

Johan Hovold (3):
soundwire: bus: suppress probe deferral errors
soundwire: bus: drop unused driver name field
soundwire: bus: clean up probe warnings

 drivers/soundwire/bus_type.c  | 19 ++++---------------
 include/linux/soundwire/sdw.h |  2 --
 2 files changed, 4 insertions(+), 17 deletions(-)
Signature · 1 line
2.44.2