clarify NVMe status symbol names
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest4 patches 7 repliesIn review
Changes in v2 from the cover letter
- Add a mailmap entry for myself.
- Rebased on nvme-6.10, dropped the patch that is already applied.
- The parameter of nvme_status_to_pr_err is renamed to "status", to make it shorter and matching the existing code.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | nvme: rename nvme_sc_to_pr_err to nvme_status_to_pr_errdrivers/ | +5 | 2 replies | |
| 2/4 | nvme: fix status magic numbersdrivers/ drivers/ drivers/ +3 more | +26 | 2 replies | |
| 3/4 | nvme: rename CDR/MORE/DNR to NVME_STATUS_*drivers/ drivers/ drivers/ +13 more | +125 | 2 replies | |
| 4/4 | mailmap: add entry for Weiwen Hu.mailmap | +1 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Christoph Hellwig | Chaitanya Kulkarni | Sagi Grimberg |
|---|---|---|---|
| Series | R-b | ||
| 1/4 | R-b | R-b | |
| 2/4 | R-b | R-b | |
| 3/4 | R-b | R-b | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/4] clarify NVMe status symbol names
This patchset clarifies the NVMe status related symbol names.
- status: the u16 field in the struct nvme_request.
- SC: status code, status & 0x00FF
- SCT: status code type, status & 0x0700
This should match the NVMe spec and most of the existing code. The exceptions are unified in this patchset.
It may be a little bit strange that we should use NVME_SCT_SC_MASK when matching the NVME_SC_* codes. But changing all the codes to NVME_SCT_SC_* requires too much changes, and making the names too long.
So I choose to keep them.
The previous version is:
https://lore.kernel.org/linux-nvme/[email protected]/T
Changes in v2:
- Add a mailmap entry for myself.
- Rebased on nvme-6.10, dropped the patch that is already applied.
- The parameter of nvme_status_to_pr_err is renamed to "status", to make it shorter and matching the existing code.
Weiwen Hu (4):
nvme: rename nvme_sc_to_pr_err to nvme_status_to_pr_err
nvme: fix status magic numbers
nvme: rename CDR/MORE/DNR to NVME_STATUS_*
mailmap: add entry for Weiwen Hu
.mailmap | 1 + drivers/nvme/host/constants.c | 2 +- drivers/nvme/host/core.c | 40 +++++++++++----------- drivers/nvme/host/fabrics.c | 10 +++--- drivers/nvme/host/fault_inject.c | 2 +- drivers/nvme/host/fc.c | 6 ++-- drivers/nvme/host/multipath.c | 2 +- drivers/nvme/host/nvme.h | 6 ++-- drivers/nvme/host/pr.c | 10 +++--- drivers/nvme/target/admin-cmd.c | 24 +++++++------- drivers/nvme/target/core.c | 46 +++++++++++++------------- drivers/nvme/target/discovery.c | 14 ++++---- drivers/nvme/target/fabrics-cmd-auth.c | 16 ++++----- drivers/nvme/target/fabrics-cmd.c | 36 ++++++++++---------- drivers/nvme/target/io-cmd-bdev.c | 12 +++---- drivers/nvme/target/passthru.c | 10 +++--- drivers/nvme/target/rdma.c | 10 +++--- drivers/nvme/target/tcp.c | 4 +-- drivers/nvme/target/zns.c | 30 ++++++++--------- include/linux/nvme.h | 16 +++++++-- 20 files changed, 154 insertions(+), 143 deletions(-)
Signature · 1 line
2.45.1