Skip to content

dlm: md: introduce DLM_LSFL_SOFTIRQ_SAFE

Alexander Aring gfs2 linux-raid 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8dlm: using rcu to avoid rsb lookup againfs/dlm/dlm_internal.h fs/dlm/lock.c fs/dlm/memory.c+112 -230 replies
2/8dlm: remove struct field with the same meaningfs/dlm/debug_fs.c fs/dlm/dlm_internal.h fs/dlm/lock.c +5 more+119 -1241 reply
3/8dlm: use is_master() on checks if we are the masterfs/dlm/lock.c fs/dlm/recoverd.c+5 -60 replies
4/8dlm: use LSFL_FS to check if it's a kernel lockspacefs/dlm/ast.c fs/dlm/dlm_internal.h fs/dlm/lockspace.c+19 -120 replies
5/8dlm: introduce DLM_LSFL_SOFTIRQ_SAFEfs/dlm/lockspace.c include/linux/dlm.h include/uapi/linux/dlm.h+21 -10 replies
6/8dlm: implement LSFL_SOFTIRQ_SAFEfs/dlm/ast.c fs/dlm/ast.h fs/dlm/dlm_internal.h +2 more+126 -840 replies
7/8dlm: convert ls_cb_lock to rwlockfs/dlm/ast.c fs/dlm/dlm_internal.h fs/dlm/lockspace.c+17 -80 replies
8/8md-cluster: use DLM_LSFL_SOFTIRQ for dlm_new_lockspace()drivers/md/md-cluster.c+1 -15 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchSong Liu
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH dlm/next 0/8] dlm: md: introduce DLM_LSFL_SOFTIRQ_SAFE

Hi,

the first three patches are resend with an updated commit message and additional comment e.g. to explain the rcu_read_lock() handling to avoid a lookup twice.

The main part are the rest of the patches introducing the DLM_LSFL_SOFTIRQ_SAFE flag to signal that ast/bast callbacks can be handled in softirq context. md-cluster is the first user here to take advantage about this flag as their callback handling is simple enough and looks okay to be called from softirq context. To be honest, I also just need a upstream user for the new flag. Other users, e.g. gfs2 can take also advantage of it.

I also gave it a try with a debug kernel and used md-cluster with 2 block devices and level mirrored. I used gfs2 on top of it and it seems to run without any problems.

This patch series is based on:

https://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git/log/?h=next

in case of md-cluster people want to try it out.

Thanks.

- Alex

Alexander Aring (8):
dlm: using rcu to avoid rsb lookup again
dlm: remove struct field with the same meaning
dlm: use is_master() on checks if we are the master
dlm: use LSFL_FS to check if it's a kernel lockspace
dlm: introduce DLM_LSFL_SOFTIRQ_SAFE
dlm: implement LSFL_SOFTIRQ_SAFE
dlm: convert ls_cb_lock to rwlock
md-cluster: use DLM_LSFL_SOFTIRQ for dlm_new_lockspace()

 drivers/md/md-cluster.c  |   2 +-
 fs/dlm/ast.c             | 185 ++++++++++++++++++---------
 fs/dlm/ast.h             |  11 +-
 fs/dlm/debug_fs.c        |  33 ++---
 fs/dlm/dlm_internal.h    |  40 +++++-
 fs/dlm/lock.c            | 268 +++++++++++++++++++++++----------------
 fs/dlm/lock.h            |   5 +-
 fs/dlm/lockspace.c       |  23 ++--
 fs/dlm/memory.c          |  15 ++-
 fs/dlm/rcom.c            |   4 +-
 fs/dlm/recover.c         |  20 +--
 fs/dlm/recoverd.c        |   2 +-
 fs/dlm/user.c            |  38 +++---
 include/linux/dlm.h      |  17 ++-
 include/uapi/linux/dlm.h |   2 +
 15 files changed, 413 insertions(+), 252 deletions(-)
Signature · 1 line
2.43.0