Skip to content

nvme: fix initialization memleak

Keith Busch linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nvme: apple: fix device reference countingdrivers/nvme/host/apple.c+22 -50 replies
2/5nvme: tcp: split controller bringup handlingdrivers/nvme/host/tcp.c+19 -60 replies
3/5nvme: rdma: split controller bringup handlingdrivers/nvme/host/rdma.c+21 -70 replies
4/5nvme: fc: split controller bringup handlingdrivers/nvme/host/fc.c+27 -160 replies
5/5nvme: split device add from initializationdrivers/nvme/host/apple.c drivers/nvme/host/core.c drivers/nvme/host/fc.c +5 more+66 -231 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChaitanya KulkarniChristoph HellwigSagi GrimbergYi Zhang
SeriesR-b R-b R-b
1/5
2/5
3/5
4/5
5/5T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/5] nvme: fix initialization memleak

From: Keith Busch <[email protected]>

I ran more of the blktests on loop in addtion to pci, also did more error injection at various points around the early initialization to make sure the kmemleak really is gone.

Changes since v1:

Use ERR_CAST() as appropriate (Christoph, Hannes)

Fix apple cleanup error (me)

Keith Busch (5):
nvme: apple: fix device reference counting
nvme: tcp: split controller bringup handling
nvme: rdma: split controller bringup handling
nvme: fc: split controller bringup handling
nvme: split device add from initialzation

 drivers/nvme/host/apple.c  | 32 +++++++++++++++++----
 drivers/nvme/host/core.c   | 58 +++++++++++++++++++++++---------------
 drivers/nvme/host/fc.c     | 48 ++++++++++++++++++++-----------
 drivers/nvme/host/nvme.h   |  1 +
 drivers/nvme/host/pci.c    |  5 ++++
 drivers/nvme/host/rdma.c   | 33 +++++++++++++++++-----
 drivers/nvme/host/tcp.c    | 30 ++++++++++++++++----
 drivers/nvme/target/loop.c |  5 ++++
 8 files changed, 155 insertions(+), 57 deletions(-)
Signature · 1 line
2.43.0