Skip to content

whack user_path_at_empty, cleanup getname_flags

Mateusz Guzik linux-fsdevel lkml 1 version Applied

Status from this message: Applied to the vfs.misc branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3vfs: stop using user_path_at_empty in do_readlinkatfs/stat.c+24 -191 reply
2/3vfs: retire user_path_at_empty and drop empty arg from getname_flagsfs/fsopen.c fs/namei.c fs/stat.c +4 more+16 -251 reply
3/3vfs: shave a branch in getname_flagsfs/namei.c+14 -113 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJan Kara
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] whack user_path_at_empty, cleanup getname_flags

I tried to take a stab at the atomic filename refcount thing [1], found some easy cleanup to do as a soft prerequisite.

user_path_at_empty saddles getname_flags with an int * argument nobody else uses, so it only results in everyone else having to pass NULL there. This is trivially avoidable.

Should a need for user_path_at_empty it can probably be implemented in a nicer manner than it was.

1: https://lore.kernel.org/linux-fsdevel/[email protected]/T/#u

Mateusz Guzik (3):
vfs: stop using user_path_at_empty in do_readlinkat
vfs: retire user_path_at_empty and drop empty arg from getname_flags
vfs: shave a branch in getname_flags

 fs/fsopen.c           |  2 +-
 fs/namei.c            | 41 +++++++++++++++++++------------------
 fs/stat.c             | 47 ++++++++++++++++++++++++-------------------
 include/linux/fs.h    |  2 +-
 include/linux/namei.h |  8 +-------
 io_uring/statx.c      |  3 +--
 io_uring/xattr.c      |  4 ++--
 7 files changed, 53 insertions(+), 54 deletions(-)
Signature · 1 line
2.39.2