Skip to content

ftrace: Clean up and comment code

Steven Rostedt linux-trace-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesIn review
  2. v15 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ftrace: Rename dup_hash() and comment itkernel/trace/ftrace.c+6 -22 replies
2/5ftrace: Remove "ftrace_hash" parameter from __ftrace_hash_rec_update()kernel/trace/ftrace.c+38 -642 replies
3/5ftrace: Add comments to ftrace_hash_rec_disable/enable()kernel/trace/ftrace.c+12 -20 replies
4/5ftrace: Convert "inc" parameter to bool in ftrace_hash_rec_update_modify()kernel/trace/ftrace.c+20 -31 reply
5/5ftrace: Add comments to ftrace_hash_move() and friendskernel/trace/ftrace.c+23 -11 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMark RutlandMasami Hiramatsu (Google)
SeriesA-b
1/5A-b A-b
2/5R-b T-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] ftrace: Clean up and comment code

While working on the function_graph multiple users code, I realized that I was struggling with how the ftrace code worked. Being the author of such code meant that it wasn't very intuitive. Namely, the function names were not descriptive enough, or at least, they needed comments.

This series moves to solve some of that via changing a couple function names and parameters and adding comments to many of them.

There's more to do, but this at least moves it in the right direction.

Changes since v1: https://lore.kernel.org/all/[email protected]/

- While working on v1 and responding to a comment from Mark Rutland about the usage of "ftrace_hash" in the __ftrace_hash_rec_update() code, I realized that the function does pretty much the same thing if it is set or not set (but slightly differently). It turns out that it isn't needed and that parameter can be removed, making the code simpler.

- Fixed some wording and typos suggested by Mark Rutland.

Steven Rostedt (Google) (5):
ftrace: Rename dup_hash() and comment it
ftrace: Remove "ftrace_hash" parameter from __ftrace_hash_rec_update()
ftrace: Add comments to ftrace_hash_rec_disable/enable()
ftrace: Convert "inc" parameter to bool in ftrace_hash_rec_update_modify()
ftrace: Add comments to ftrace_hash_move() and friends

----

 kernel/trace/ftrace.c | 161 +++++++++++++++++++++++++++++---------------------
 1 file changed, 94 insertions(+), 67 deletions(-)