Skip to content

Fix DM zone resource limits stacking

Damien Le Moal dm-devel linux-block 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest4 patches 1 replyApplied
  2. v74 patches 1 replySuperseded
  3. v64 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v54 patches6 repliesSuperseded
v43 patches14 repliesSuperseded
v32 patches4 repliesSuperseded
v22 patches5 repliesSuperseded

Changes in v8 from the cover letter

- Moved v7 changes mistakenly added to patch 4 to patch 3 where they belong.

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/4block: Improve checks on zone resource limitsblock/blk-settings.c block/blk-zoned.c+24 -40 replies
2/4dm: Call dm_revalidate_zones() after setting the queue limitsdrivers/md/dm-table.c drivers/md/dm-zone.c drivers/md/dm.h+22 -190 replies
3/4dm: Improve zone resource limits handlingdrivers/md/dm-zone.c+150 -300 replies
4/4dm: Remove unused macro DM_ZONE_INVALID_WP_OFSTdrivers/md/dm-zone.c+0 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigJohannes ThumshirnNiklas CasselBenjamin Marzinski
1/4R-b R-b R-b
2/4R-b R-b R-b
3/4R-b R-b R-b
4/4R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/4] Fix DM zone resource limits stacking

This is the updated patch 4/4 of the series "Zone write plugging and DM zone fixes". This patch fixes DM zone resource limits stacking (max open zones and max active zones limits). Patch 1 is new and is added to help catch problems and eventual regressions of the handling of these limits.

Changes from v7:
- Moved v7 changes mistakenly added to patch 4 to patch 3 where they belong.

Changes from v6:
- Modified patch 3 as suggested by Niklas (moved the increment of zlim->mapped_nr_seq_zones after handling zc.target_nr_seq_zones == 0)
- Rebased on rc3
- Added review tags

Changes from v5:
- Corrected typo in comment in patch 2
- Simplyfied patch 3 by removing the function dm_set_zone_resources() and integrating its code directly in dm_set_zone_restrictions().
- Added review tags

Changes from v4:
- Fixed a typo in a comment in patch 1
- Added patch 2 and changed patch 3 accordingly
- Added review tags

Changes from v3:
- Modify patch 1 to always check the zone resource limits values in disk_update_zone_resources(), including for DM devices that do not use zone write plugging. Simplify patch 2 accordingly by removing the same check and adjustment of the zone resource limits.
- Added patch 3

Changes from v2:
- Modify patch 1 to return an error for the case where the max open zones limit is greater than the max active zones limit.
- Modify patch 2 to avoid duplicated actions on the limits and to remove warnings for unusual zone limits.

Changes from v1:
- Added patch 1
- Modified patch 2 to not cap the limits for a target with the number of sequential zones mapped but rather to use the device limits as is when more zones than the limits are mapped and 0 otherwise (no limits).

Damien Le Moal (4):
block: Improve checks on zone resource limits
dm: Call dm_revalidate_zones() after setting the queue limits
dm: Improve zone resource limits handling
dm: Remove unused macro DM_ZONE_INVALID_WP_OFST

 block/blk-settings.c  |   8 ++
 block/blk-zoned.c     |  20 ++++-
 drivers/md/dm-table.c |  15 +++-
 drivers/md/dm-zone.c  | 205 ++++++++++++++++++++++++++++++++----------
 drivers/md/dm.h       |   1 +
 5 files changed, 195 insertions(+), 54 deletions(-)
Signature · 1 line
2.45.2